public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] configs: am65x_evm: Use envboot before distro_bootcmd
@ 2023-09-08 11:56 Devarsh Thakkar
  2023-09-08 13:42 ` Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Devarsh Thakkar @ 2023-09-08 11:56 UTC (permalink / raw)
  To: u-boot, trini
  Cc: praneeth, nm, vigneshr, a-bhatia1, j-luthra, devarsht, nsekhar,
	jan.kiszka, chao.zeng

Use envboot cmd before issuring distro_bootcmd as otherwise
environment variables from uEnv.txt are not getting imported.

The commands after distro_bootcmd have no impact since board starts
booting after distro_bootcmd, so it need to run last after all
environment variables are configured correctly.

Fixes: bde6ac54905 ("configs: am65x_evm: Switch envboot out for
distro_bootcmd")

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
Boot logs (with display overlay) :
https://gist.github.com/devarsht/2bac56933847d3e954d6ee275d711e27
---
 configs/am65x_evm_a53_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
index 4301553af8..4f1ef10e69 100644
--- a/configs/am65x_evm_a53_defconfig
+++ b/configs/am65x_evm_a53_defconfig
@@ -34,7 +34,7 @@ CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
 CONFIG_OF_SYSTEM_SETUP=y
 CONFIG_DISTRO_DEFAULTS=y
-CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run boot_rprocs; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
+CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
 CONFIG_LOGLEVEL=7
 CONFIG_CONSOLE_MUX=y
 CONFIG_SPL_MAX_SIZE=0x58000
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] configs: am65x_evm: Use envboot before distro_bootcmd
  2023-09-08 11:56 [PATCH] configs: am65x_evm: Use envboot before distro_bootcmd Devarsh Thakkar
@ 2023-09-08 13:42 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2023-09-08 13:42 UTC (permalink / raw)
  To: Devarsh Thakkar
  Cc: u-boot, praneeth, nm, vigneshr, a-bhatia1, j-luthra, nsekhar,
	jan.kiszka, chao.zeng

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

On Fri, Sep 08, 2023 at 05:26:15PM +0530, Devarsh Thakkar wrote:

> Use envboot cmd before issuring distro_bootcmd as otherwise
> environment variables from uEnv.txt are not getting imported.
> 
> The commands after distro_bootcmd have no impact since board starts
> booting after distro_bootcmd, so it need to run last after all
> environment variables are configured correctly.
> 
> Fixes: bde6ac54905 ("configs: am65x_evm: Switch envboot out for
> distro_bootcmd")
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> Boot logs (with display overlay) :
> https://gist.github.com/devarsht/2bac56933847d3e954d6ee275d711e27
> ---
>  configs/am65x_evm_a53_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/am65x_evm_a53_defconfig b/configs/am65x_evm_a53_defconfig
> index 4301553af8..4f1ef10e69 100644
> --- a/configs/am65x_evm_a53_defconfig
> +++ b/configs/am65x_evm_a53_defconfig
> @@ -34,7 +34,7 @@ CONFIG_SPL_LOAD_FIT=y
>  CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
>  CONFIG_OF_SYSTEM_SETUP=y
>  CONFIG_DISTRO_DEFAULTS=y
> -CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run boot_rprocs; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
> +CONFIG_BOOTCOMMAND="run envboot; run distro_bootcmd;"
>  CONFIG_LOGLEVEL=7
>  CONFIG_CONSOLE_MUX=y
>  CONFIG_SPL_MAX_SIZE=0x58000

This should just be switched to standard boot instead.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-08 13:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-08 11:56 [PATCH] configs: am65x_evm: Use envboot before distro_bootcmd Devarsh Thakkar
2023-09-08 13:42 ` Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox