From: Trevor Woerner <twoerner@gmail.com>
To: Nishanth Menon <nm@ti.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Pierre Lebleu <pierre.lebleu@pile-engineering.com>,
Andrew Davis <afd@ti.com>
Subject: Re: [PATCH] ARM: dts: am335x-pocketbeagle: choose tick-timer
Date: Sat, 9 Sep 2023 09:27:34 -0400 [thread overview]
Message-ID: <20230909132734.GA9887@localhost> (raw)
In-Reply-To: <20230908173617.7c2xto3n4hqltnf2@ferris>
On Fri 2023-09-08 @ 12:36:17 PM, Nishanth Menon wrote:
> On 11:25-20230830, Trevor Woerner wrote:
> > Commit 4b2be78ab66c ("time: Fix get_ticks being non-monotonic")
> > requires '/chosen/tick-timer' in device-tree. Otherwise we get:
> >
> > U-Boot 2023.07.02 (Jul 11 2023 - 15:20:44 +0000)
> >
> > CPU : AM335X-GP rev 2.1
> > Model: TI AM335x PocketBeagle
> > DRAM: 512 MiB
> > Core: 154 devices, 16 uclasses, devicetree: separate
> > Could not initialize timer (err -19)
> >
> > resetting ...
> >
> > Suggested-by: Pierre Lebleu <pierre.lebleu@pile-engineering.com>
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> > arch/arm/dts/am335x-pocketbeagle.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/dts/am335x-pocketbeagle.dts b/arch/arm/dts/am335x-pocketbeagle.dts
> > index b379e3a5570d..02e3aac56064 100644
> > --- a/arch/arm/dts/am335x-pocketbeagle.dts
> > +++ b/arch/arm/dts/am335x-pocketbeagle.dts
> > @@ -15,6 +15,7 @@
> >
> > chosen {
> > stdout-path = &uart0;
> > + tick-timer = &timer2;
> > };
> >
> > leds {
> > --
> > 2.41.0.327.gaa9166bcc0ba
> >
>
> Does enabling CONFIG_SYS_ARCH_TIMER solve this?
Enabling CONFIG_SYS_ARCH_TIMER causes the following compile error:
| arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `timer_init':
| /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:29: multiple definition of `timer_init'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:44: first defined here
| arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `get_ticks':
| /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:44: multiple definition of `get_ticks'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:97: first defined here
| arm-oe-linux-gnueabi-ld.bfd: arch/arm/cpu/armv7/arch_timer.o: in function `get_tbclk':
| /z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/cpu/armv7/arch_timer.c:63: multiple definition of `get_tbclk'; arch/arm/mach-omap2/timer.o:/z/build-master/pocketbeagle/build/tmp-glibc/work/pocketbeagle-oe-linux-gnueabi/u-boot/2023.07.02/git/arch/arm/mach-omap2/timer.c:108: first defined here
Without CONFIG_SYS_ARCH_TIMER, the functions timer_init(), get_ticks(), and
get_tbclk() are defined in arch/arm/mach-omap2/timer.c. When
CONFIG_SYS_ARCH_TIMER is defined, it also pulls in the file
arch/arm/cpu/armv7/arch_timer.c.
There is a config option, CONFIG_TIMER, that controls the inclusion of
arch/arm/mach-omap2/timer.c, but it is unconditional during SPL:
arch/arm/mach-omap2/Makefile
...
12 ifeq ($(CONFIG_TIMER),)
13 obj-y += timer.o
14 else
15 ifdef CONFIG_SPL_BUILD
16 obj-y += timer.o
17 endif
18 endif
...
So whether CONFIG_TIMER is defined or not, a compile error will result if
CONFIG_SYS_ARCH_TIMER is also defined.
Getting the code to compile with CONFIG_SYS_ARCH_TIMER would require a deeper
reworking of the configuration/Make logic in order to swap out the functions
in arch/arm/mach-omap2/timer.c for the ones in
arch/arm/cpu/armv7/arch_timer.c. The definitions of those functions in both
those locations are quite different, so even after getting the build to work
there's no guarantee the arch functions would work.
Best regards,
Trevor
next prev parent reply other threads:[~2023-09-09 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 15:25 [PATCH] ARM: dts: am335x-pocketbeagle: choose tick-timer Trevor Woerner
2023-09-08 16:00 ` Robert Nelson
2023-09-08 17:36 ` Nishanth Menon
2023-09-09 13:27 ` Trevor Woerner [this message]
2023-09-11 11:06 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230909132734.GA9887@localhost \
--to=twoerner@gmail.com \
--cc=afd@ti.com \
--cc=nm@ti.com \
--cc=pierre.lebleu@pile-engineering.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox