From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47516CD13CF for ; Sun, 17 Sep 2023 21:10:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 03729865AB; Sun, 17 Sep 2023 23:10:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=arvanta.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 50421866DC; Sun, 17 Sep 2023 23:10:37 +0200 (CEST) Received: from fx.arvanta.net (unknown [109.72.52.77]) by phobos.denx.de (Postfix) with ESMTP id 2D1AF86589 for ; Sun, 17 Sep 2023 23:10:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=arvanta.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mps@arvanta.net Received: from m1 (m1pro.arvanta.net [10.5.1.5]) by fx.arvanta.net (Postfix) with ESMTP id 918AE2865A; Sun, 17 Sep 2023 23:10:33 +0200 (CEST) Date: Sun, 17 Sep 2023 23:10:32 +0200 From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= To: Heinrich Schuchardt Cc: Rick Chen , Leo , Yanhong Wang , Simon Glass , Marc Kleine-Budde , Chanho Park , Massimo Pegorer , Jonas Karlman , u-boot@lists.denx.de Subject: Re: [PATCH v3 2/2] riscv: dts: starfive: generate u-boot-spl.bin.normal.out Message-ID: <20230917211032.GA19446@m1> References: <20230917114731.23695-1-heinrich.schuchardt@canonical.com> <20230917114731.23695-3-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230917114731.23695-3-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, 2023-09-17 at 13:47, Heinrich Schuchardt wrote: > The StarFive VisionFive 2 board cannot load spl/u-boot-spl.bin but needs a > prefixed header. We have referring to a vendor tool (spl_tool) for this > task. 'mkimage -T sfspl' can generate the prefixed file. > > Use binman to invoke mkimage for the generation of file > spl/u-boot-spl.bin.normal.out. > > Update the documentation. > > Signed-off-by: Heinrich Schuchardt Tested-by: Milan P. Stanić > --- > v3: > Rename binman node for SPL image. > Use u-boot-spl instead of blob as mkimage subnode. > v2: > Fix a typo in a comment in tools/sfspl.c > Add Tested-by credits > --- > .../dts/jh7110-starfive-visionfive-2-u-boot.dtsi | 11 +++++++++++ > doc/board/starfive/visionfive2.rst | 14 ++------------ > 2 files changed, 13 insertions(+), 12 deletions(-) > > diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2-u-boot.dtsi b/arch/riscv/dts/jh7110-starfive-visionfive-2-u-boot.dtsi > index 13f69da31e..55185314dd 100644 > --- a/arch/riscv/dts/jh7110-starfive-visionfive-2-u-boot.dtsi > +++ b/arch/riscv/dts/jh7110-starfive-visionfive-2-u-boot.dtsi > @@ -103,4 +103,15 @@ > }; > }; > }; > + > + spl-img { > + filename = "spl/u-boot-spl.bin.normal.out"; > + > + mkimage { > + args = "-T sfspl"; > + > + u-boot-spl { > + }; > + }; > +}; > }; > diff --git a/doc/board/starfive/visionfive2.rst b/doc/board/starfive/visionfive2.rst > index 941899a0a4..f5575ab68b 100644 > --- a/doc/board/starfive/visionfive2.rst > +++ b/doc/board/starfive/visionfive2.rst > @@ -65,18 +65,8 @@ Now build the U-Boot SPL and U-Boot proper > make starfive_visionfive2_defconfig > make OPENSBI=$(opensbi_dir)/opensbi/build/platform/generic/firmware/fw_dynamic.bin > > -This will generate spl/u-boot-spl.bin and FIT image (u-boot.itb) > - > -u-boot-spl.bin cannot be used directly on StarFive VisionFive2,we need > -to convert the u-boot-spl.bin to u-boot-spl.bin.normal.out with > -the below command: > - > - ./spl_tool -c -f $(Uboot_PATH)/spl/u-boot-spl.bin > - > -More detailed description of spl_tool,please refer spl_tool documenation. > -(Note: spl_tool git repo is at https://github.com/starfive-tech/Tools/tree/master/spl_tool) > - > -This will generate u-boot-spl.bin.normal.out file. > +This will generate the U-Boot SPL image (spl/u-boot-spl.bin.normal.out) as well > +as the FIT image (u-boot.itb) with OpenSBI and U-Boot. > > Flashing > ~~~~~~~~ > -- > 2.40.1 >