From: Tom Rini <trini@konsulko.com>
To: Trevor Woerner <twoerner@gmail.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Simon Glass <sjg@chromium.org>, Bin Meng <bmeng.cn@gmail.com>,
Michal Suchanek <msuchanek@suse.de>
Subject: Re: [PATCH] am33xx: ignore return value from usb_ether_init()
Date: Tue, 19 Sep 2023 11:14:22 -0400 [thread overview]
Message-ID: <20230919151422.GF305624@bill-the-cat> (raw)
In-Reply-To: <20230831024951.22599-1-twoerner@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Wed, Aug 30, 2023 at 10:49:50PM -0400, Trevor Woerner wrote:
> In 2cb43ef1c223 ("usb: ether: Fix error handling in usb_ether_init") the error
> handling of usb_ether_init() was changed. Not a single other call site of this
> function checks its return value, therefore follow suit in the am33xx code.
>
> Do not cause the boot to halt if the usb gadget ethernet initialization fails:
>
> initcall sequence 9ffdbd84 failed at call 808024b9 (err=-19)
> ### ERROR ### Please RESET the board ###
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> Reviewed-by: Michal Suchánek <msuchanek@suse.de>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-09-19 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 2:49 [PATCH] am33xx: ignore return value from usb_ether_init() Trevor Woerner
2023-08-31 10:15 ` Michal Suchánek
2023-09-13 12:50 ` Trevor Woerner
2023-09-13 18:32 ` Tom Rini
2023-09-13 18:42 ` Trevor Woerner
2023-09-19 15:14 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919151422.GF305624@bill-the-cat \
--to=trini@konsulko.com \
--cc=bmeng.cn@gmail.com \
--cc=msuchanek@suse.de \
--cc=sjg@chromium.org \
--cc=twoerner@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox