From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Angus Ainslie <angus@akkea.ca>,
Dmitrii Merkurev <dimorinny@google.com>,
Eddie Cai <eddie.cai.linux@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Lukasz Majewski <lukma@denx.de>, Nishanth Menon <nm@ti.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
kernel@puri.sm
Subject: Re: [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions
Date: Fri, 22 Sep 2023 12:00:12 +0200 [thread overview]
Message-ID: <20230922120012.6e24645f@xps-13> (raw)
In-Reply-To: <20230901095003.352930-1-marex@denx.de>
Hi Marek,
I'm answering here as there is no cover letter. Just to let you know
I'm still concerned by the series and want to test it but did not had
the time to do so recently. Hopefully next week.
Sorry for the delay.
Miquèl
marex@denx.de wrote on Fri, 1 Sep 2023 11:49:47 +0200:
> Pull the functionality of UDC uclass that operates on plain udevice
> and does not use this dev_array array into separate functions and
> expose those functions, so that as much code as possible can be
> switched over to these functions and the dev_array can be dropped.
>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: Dmitrii Merkurev <dimorinny@google.com>
> Cc: Eddie Cai <eddie.cai.linux@gmail.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefan Roese <sr@denx.de>
> Cc: kernel@puri.sm
> ---
> V2: Add RB from Mattijs
> ---
> drivers/usb/gadget/udc/Makefile | 2 +-
> drivers/usb/gadget/udc/udc-uclass.c | 57 +++++++++++++++++++++++++----
> include/linux/usb/gadget.h | 17 +++++++++
> 3 files changed, 68 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2023-09-22 10:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 9:49 [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions Marek Vasut
2023-09-01 9:49 ` [PATCH v2 02/17] usb: sandbox: Add DM_USB_GADGET support Marek Vasut
2023-09-01 9:49 ` [PATCH v2 03/17] configs: sandbox: Enable DM_USB_GADGET Marek Vasut
2023-09-01 9:49 ` [PATCH v2 04/17] cmd: fastboot: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 05/17] cmd: rockusb: " Marek Vasut
2023-09-04 7:37 ` Mattijs Korpershoek
2023-09-01 9:49 ` [PATCH v2 06/17] cmd: sdp: Reorder variable declaration Marek Vasut
2023-09-01 9:49 ` [PATCH v2 07/17] cmd: thordown: " Marek Vasut
2023-09-04 7:40 ` Mattijs Korpershoek
2023-09-01 9:49 ` [PATCH v2 08/17] cmd: ums: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 09/17] dfu: Detach the controller on error Marek Vasut
2023-09-01 9:49 ` [PATCH v2 10/17] dfu: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 11/17] spl: sdp: Detach the controller on error Marek Vasut
2023-09-01 9:49 ` [PATCH v2 12/17] sdp: Use plain udevice for UDC controller interaction Marek Vasut
2023-09-01 9:49 ` [PATCH v2 13/17] thordown: " Marek Vasut
2023-09-04 7:45 ` Mattijs Korpershoek
2023-09-01 9:50 ` [PATCH v2 14/17] usb: gadget: acm: " Marek Vasut
2023-09-04 7:46 ` Mattijs Korpershoek
2023-09-01 9:50 ` [PATCH v2 15/17] usb: gadget: ether: " Marek Vasut
2023-09-04 7:56 ` Mattijs Korpershoek
2023-09-04 9:10 ` Marek Vasut
2023-09-04 15:37 ` Mattijs Korpershoek
2023-09-01 9:50 ` [PATCH v2 16/17] dm: usb: udc: Drop legacy udevice handler functions Marek Vasut
2023-09-01 9:50 ` [PATCH v2 17/17] board: usb: Replace legacy usb_gadget_handle_interrupts() Marek Vasut
2023-09-22 10:00 ` Miquel Raynal [this message]
2023-09-27 13:59 ` [PATCH v2 01/17] dm: usb: udc: Factor out plain udevice handler functions Miquel Raynal
2023-09-30 21:11 ` Marek Vasut
2023-10-02 13:42 ` Miquel Raynal
2023-10-07 21:01 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922120012.6e24645f@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=angus@akkea.ca \
--cc=dimorinny@google.com \
--cc=eddie.cai.linux@gmail.com \
--cc=kernel@puri.sm \
--cc=kever.yang@rock-chips.com \
--cc=lukma@denx.de \
--cc=marex@denx.de \
--cc=mkorpershoek@baylibre.com \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox