From: Tom Rini <trini@konsulko.com>
To: Maxim Uvarov <maxim.uvarov@linaro.org>
Cc: Simon Glass <sjg@google.com>,
u-boot@lists.denx.de, pbrobinson@gmail.com,
ilias.apalodimas@linaro.org, joe.hershberger@ni.com,
rfried.dev@gmail.com, goldsimon@gmx.de
Subject: Re: [PATCHv10 01/15] submodule: add lwIP as git submodule
Date: Wed, 4 Oct 2023 12:02:03 -0400 [thread overview]
Message-ID: <20231004160203.GG8465@bill-the-cat> (raw)
In-Reply-To: <CAD8XO3Z87tOqMx4gmipRfwnMY-U9Sr0Bf21GtKCgq=Ay+Jtakw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
On Wed, Oct 04, 2023 at 01:52:53PM +0600, Maxim Uvarov wrote:
> On Mon, 2 Oct 2023 at 20:46, Simon Glass <sjg@google.com> wrote:
>
> > Hi Maxim,
> >
> > On Mon, 2 Oct 2023 at 05:23, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> > >
> > > I found what was missing. (reproduced with CI docker.)
> >
> > How about adding a script that copies in the lwip code needed for
> > U-Boot, that you (or whoever the maintainer is) can run each quarter?
> >
> > Alternatively, I think just sending a patch with the code would be
> > helpful, so we can see what you are wanting to include.
> >
> > Regards,
> > Simon
> >
>
> Hello Simon,
>
> That might also work. lwIP is a little bit special library which we can not
> just connect as an external library from the repo, because it has
> platform implementation specifics (U-Boot here).
> At this time I'm trying to pass all CI tests. And even if they pass for me
> locally CI has some interesting combinations where the test fails and I'm
> not even sure that it's related to lwip code.
> Once CI will pass all the things I want to take more attention on submodule
> support or patch support. I really hope that submodule will work for us,
> but that also will require Makefile and CI changes.
>
> However, review of lwIP code here might be helpful. But I think the mailing
> list will not allow me to send such a big patch, and it's almost impossible
> to do a review project in one email.
> I guess it's better to do a git clone
> https://git.savannah.nongnu.org/git/lwip.git and see what is there.
Yes, the mailing list will hold the message for moderation until I, or
one of the other people with the password approve it. That's not a
consideration for how we handle the initial lwip integration. It does
need to be a "just the import" patch as there's no real way to review
the code itself.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-10-04 16:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 9:41 [PATCHv10 00/15] net/lwip: add lwip library for the network stack Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 01/15] submodule: add lwIP as git submodule Maxim Uvarov
2023-09-26 11:37 ` Simon Glass
2023-09-26 13:41 ` Tom Rini
2023-09-26 14:16 ` Simon Glass
2023-09-26 14:19 ` Tom Rini
2023-10-02 6:34 ` Maxim Uvarov
2023-10-02 11:23 ` Maxim Uvarov
2023-10-02 14:46 ` Simon Glass
2023-10-04 7:52 ` Maxim Uvarov
2023-10-04 16:02 ` Tom Rini [this message]
2023-10-04 16:06 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 02/15] Makefile: init submodules Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 03/15] net/lwip: add doc/develop/net_lwip.rst Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 04/15] net/lwip: integrate lwIP library Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 05/15] net/lwip: implement dns cmd Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 06/15] net/lwip: implement dhcp cmd Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 07/15] net/lwip: implement tftp cmd Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 08/15] net/lwip: implement wget cmd Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 09/15] net/lwip: implement ping cmd Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 10/15] net/lwip: add lwIP configuration Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 11/15] net/lwip: implement lwIP port to U-Boot Maxim Uvarov
2023-09-26 9:41 ` [PATCHv10 12/15] net/lwip: update .gitignore with lwIP Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 13/15] net/lwip: connection between cmd and lwip apps Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-09-26 9:41 ` [PATCHv10 14/15] net/lwip: replace original net commands with lwip Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
2023-10-03 17:58 ` Sean Edmond
2023-10-03 21:58 ` Peter Robinson
2023-10-03 23:44 ` Sean Edmond
2023-10-04 2:11 ` Simon Glass
2023-10-04 8:29 ` Maxim Uvarov
2023-10-04 20:14 ` Simon Goldschmidt
2023-09-26 9:41 ` [PATCHv10 15/15] net/lwip: split net.h to net.h, arp.h and eth.h Maxim Uvarov
2023-10-02 1:17 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004160203.GG8465@bill-the-cat \
--to=trini@konsulko.com \
--cc=goldsimon@gmx.de \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=maxim.uvarov@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@google.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox