From: Tom Rini <trini@konsulko.com>
To: Nishanth Menon <nm@ti.com>
Cc: Simon Glass <sjg@chromium.org>, Roger Quadros <rogerq@kernel.org>,
vigneshr@ti.com, m-chawdhry@ti.com, jonas@kwiboo.se, srk@ti.com,
afd@ti.com, bb@ti.com, praneeth@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] board: ti: am64x: Switch to standard boot flow
Date: Thu, 5 Oct 2023 13:19:08 -0400 [thread overview]
Message-ID: <20231005171908.GT8465@bill-the-cat> (raw)
In-Reply-To: <20231005171407.jijjxbt66vakivap@chemicals>
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
On Thu, Oct 05, 2023 at 12:14:07PM -0500, Nishanth Menon wrote:
> On 12:31-20231005, Tom Rini wrote:
> [...]
>
> > > > /* Now for the remaining common defines */
> > > > #include <configs/ti_armv7_common.h>
> > >
> > > It looks like this file still includes distro_bootcmd and defines all
> > > the BOOT_TARGET things. Can they be dropped? Perhaps for now they
> > > could be put behind an #ifdef if other boards need them?
> > >
> > > I suspect that with your patch as is, the environment is still full of scripts?
> >
> > There's a lot of TI platforms, so I'm not sure what "#if" you're
> > thinking of might make it cleaner? We could / should move some of the
> > still relevant content and comments from that file to
> > include/env/ti/ti_armv7_common.env as I do think some of the K3
> > platforms could just drop <configs/ti_armv7_common.h> at this point.
>
> Is'nt the header distro_bootcmd.h and related stuff under #ifdef
> CONFIG_DISTRO_DEFAULTS already?
That's true too. The file (and probably all of the other *common.h
ones) likely need some cleaning out of dead comments, etc, from the
Kconfig migration.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-10-05 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 13:06 [PATCH v2 0/2] board: ti: am6x: Switch to standard boot Roger Quadros
2023-10-05 13:06 ` [PATCH v2 1/2] board: ti: am62x: am62x.env: Fix boot_targets Roger Quadros
2023-10-12 21:03 ` Tom Rini
2023-10-05 13:06 ` [PATCH v2 2/2] board: ti: am64x: Switch to standard boot flow Roger Quadros
2023-10-05 13:30 ` Nishanth Menon
2023-10-05 15:01 ` Simon Glass
2023-10-05 16:31 ` Tom Rini
2023-10-05 17:14 ` Nishanth Menon
2023-10-05 17:19 ` Tom Rini [this message]
2023-10-05 17:22 ` Simon Glass
2023-10-06 9:53 ` Roger Quadros
2023-10-12 21:03 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005171908.GT8465@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=jonas@kwiboo.se \
--cc=m-chawdhry@ti.com \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=srk@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox