public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v2 0/1] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board
@ 2023-10-08 18:46 John Clark
  2023-10-08 18:46 ` [PATCH v2 1/1] " John Clark
  0 siblings, 1 reply; 2+ messages in thread
From: John Clark @ 2023-10-08 18:46 UTC (permalink / raw)
  To: u-boot
  Cc: John Clark, Chris Morgan, Eugen Hristev, FUKAUMI Naoki,
	Jagan Teki, Johan Jonker, Jonas Karlman, Kever Yang, Michal Simek,
	Nicolas Frattaroli, Philipp Tomsich, Philipp Tomsich, Simon Glass,
	Stefan Bosch

Jonas, thank you for your detailed review.  The explanations for each of config change recommendations were especially helpful.

As for the CFG_IRAM_BASE / BROM_LAST_BOOTSOURCE issue, I have made a step forward, but expect I will be getting feedback as to a better approach.

Note: This patchset is based on Kever's most recent pull request "u-boot-rockchip-20231007" which, as of this writing, has yet to be merged upstream.

Finally, I would appreciate any insight as to FriendlyElec vs FriendlyARM naming.  Currently, I have documented this as the "FriendlyARM NanoPC-T6" but it would seem that it could also be called the "FriendlyElec NanoPC-T6" and be equally correct.  It is worth noting that u-boot currently contains support for the "FriendlyARM NanoPi2" board/friendlyarm/nanopi2 and thus my use of FriendlyARM.

Changes in v2:
- resync dt from:
    https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/plain/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts?h=for-next
- config changes:
    -CONFIG_PCI_INIT_R=y
    -CONFIG_SYS_SPI_U_BOOT_OFFS=0x100000
    +CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000
    -CONFIG_REGULATOR_PWM=y
    -# CONFIG_USB_XHCI_DWC3_OF_SIMPLE is not set
    -CONFIG_SPL_USB_DWC3_GENERIC=y
- added board files:
    create mode 100644 board/friendlyarm/nanopct6-rk3588/Kconfig
    create mode 100644 board/friendlyarm/nanopct6-rk3588/MAINTAINERS
    create mode 100644 board/friendlyarm/nanopct6-rk3588/Makefile
    create mode 100644 board/friendlyarm/nanopct6-rk3588/nanopct6-rk3588.c
    create mode 100644 include/configs/nanopct6-rk3588.h
- improved BROM_LAST_BOOTSOURCE handling for SPI NOR:
    if (CONFIG_IS_ENABLED(TARGET_NANOPCT6_RK3588) && bootdevice_brom_id == 4)
        bootdevice_ofpath = boot_devices[BROM_BOOTSOURCE_SPINOR];
    else
        bootdevice_ofpath = boot_devices[bootdevice_brom_id];

-- 
2.42.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-08 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-08 18:46 [PATCH v2 0/1] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board John Clark
2023-10-08 18:46 ` [PATCH v2 1/1] " John Clark

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox