From: Tom Rini <trini@konsulko.com>
To: Patryk Biel <pbiel7@gmail.com>
Cc: u-boot@lists.denx.de, Kristian Amlie <kristian.amlie@northern.tech>
Subject: Re: [PATCH] ARM: vexpress_ca9x4: Add missing flash width config option
Date: Tue, 10 Oct 2023 08:58:45 -0400 [thread overview]
Message-ID: <20231010125845.GD2227687@bill-the-cat> (raw)
In-Reply-To: <20230920074120.394487-1-pbiel7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On Wed, Sep 20, 2023 at 09:41:20AM +0200, Patryk Biel wrote:
> Allow for a proper configuration of CFI flash banks avaialble on the vexpress_ca9x4
> board. Without this option, the CFI flash incorrectly detects that the board has two
> banks of 32MB flash devices, while in reality, the board provides
> two flash banks, each with 64MB size. As a result, it becomes impossible to e.g. to
> save u-boot env in flash. According to device tree for this board and
> its implementation in QEMU, the CFI width should be set to 32 bits.
>
> After applying this fix, CFI flash will correctly detect both flash
> banks each with a size of 64MB. As as result the functionality of e.g. saving u-boot
> env will work correctly.
>
> Tested on QEMU 6.2.0.
>
> Cc: Kristian Amlie <kristian.amlie@northern.tech>
> Signed-off-by: Patryk Biel <pbiel7@gmail.com>
> Reviewed-by: Kristian Amlie <kristian.amlie@northern.tech>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-10-10 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 7:41 [PATCH] ARM: vexpress_ca9x4: Add missing flash width config option Patryk Biel
2023-09-21 8:32 ` Kristian Amlie
2023-10-10 12:58 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010125845.GD2227687@bill-the-cat \
--to=trini@konsulko.com \
--cc=kristian.amlie@northern.tech \
--cc=pbiel7@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox