public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] smegw01: Remove misuse of CONFIG_ENV_IS_NOWHERE
@ 2023-10-10 14:14 Fabio Estevam
  2023-10-16  9:21 ` sbabic
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-10-10 14:14 UTC (permalink / raw)
  To: sbabic; +Cc: u-boot, Eduard Strehlau, Fabio Estevam

From: Eduard Strehlau <eduard@lionizers.com>

When using a list of writeable variables, the initial values come
from the built-in default environment since commit 5ab81058364b ("env:
Complete generic support for writable list").

Remove unnecessary misuse of CONFIG_ENV_IS_NOWHERE as default environment.

Based on the fix done by commit b16fd7f75f6d ("imx6q: acc: Remove misuse
of env is nowhere driver").

Signed-off-by: Eduard Strehlau <eduard@lionizers.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 board/storopack/smegw01/smegw01.c | 15 ---------------
 configs/smegw01_defconfig         |  1 -
 2 files changed, 16 deletions(-)

diff --git a/board/storopack/smegw01/smegw01.c b/board/storopack/smegw01/smegw01.c
index 7b2c50a61e..345191b31c 100644
--- a/board/storopack/smegw01/smegw01.c
+++ b/board/storopack/smegw01/smegw01.c
@@ -111,18 +111,3 @@ uint mmc_get_env_part(struct mmc *mmc)
 	return part;
 }
 
-enum env_location env_get_location(enum env_operation op, int prio)
-{
-	if (op == ENVOP_SAVE || op == ENVOP_ERASE)
-		return ENVL_MMC;
-
-	switch (prio) {
-	case 0:
-		return ENVL_NOWHERE;
-
-	case 1:
-		return ENVL_MMC;
-	}
-
-	return ENVL_UNKNOWN;
-}
diff --git a/configs/smegw01_defconfig b/configs/smegw01_defconfig
index 5cfd3d2715..13665ecfd3 100644
--- a/configs/smegw01_defconfig
+++ b/configs/smegw01_defconfig
@@ -48,7 +48,6 @@ CONFIG_CMD_SQUASHFS=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_OVERWRITE=y
-CONFIG_ENV_IS_NOWHERE=y
 CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
 CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_SYS_MMC_ENV_DEV=1
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] smegw01: Remove misuse of CONFIG_ENV_IS_NOWHERE
  2023-10-10 14:14 [PATCH] smegw01: Remove misuse of CONFIG_ENV_IS_NOWHERE Fabio Estevam
@ 2023-10-16  9:21 ` sbabic
  0 siblings, 0 replies; 2+ messages in thread
From: sbabic @ 2023-10-16  9:21 UTC (permalink / raw)
  To: Fabio Estevam, u-boot

> From: Eduard Strehlau <eduard@lionizers.com>
> When using a list of writeable variables, the initial values come
> from the built-in default environment since commit 5ab81058364b ("env:
> Complete generic support for writable list").
> Remove unnecessary misuse of CONFIG_ENV_IS_NOWHERE as default environment.
> Based on the fix done by commit b16fd7f75f6d ("imx6q: acc: Remove misuse
> of env is nowhere driver").
> Signed-off-by: Eduard Strehlau <eduard@lionizers.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-16  9:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 14:14 [PATCH] smegw01: Remove misuse of CONFIG_ENV_IS_NOWHERE Fabio Estevam
2023-10-16  9:21 ` sbabic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox