public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: u-boot@lists.denx.de
Cc: ilias.apalodimas@linaro.org, sjg@chromium.org,
	xypron.glpk@gmx.de, eajames@linux.ibm.com
Subject: [PATCH v12 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks
Date: Thu, 12 Oct 2023 09:45:50 -0500	[thread overview]
Message-ID: <20231012144551.679551-8-eajames@linux.ibm.com> (raw)
In-Reply-To: <20231012144551.679551-1-eajames@linux.ibm.com>

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>

efi_tcg2_get_active_pcr_banks doesn't immediately call the
EFI_ENTRY() wrapper once it enters the function. Move the call a
few lines above to cover the error cases properly as well.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 lib/efi_loader/efi_tcg2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
index 7ada536568..dae1b166c8 100644
--- a/lib/efi_loader/efi_tcg2.c
+++ b/lib/efi_loader/efi_tcg2.c
@@ -949,16 +949,16 @@ efi_tcg2_get_active_pcr_banks(struct efi_tcg2_protocol *this,
 	struct udevice *dev;
 	efi_status_t ret;
 
+	EFI_ENTRY("%p, %p", this, active_pcr_banks);
+
 	if (!this || !active_pcr_banks) {
 		ret = EFI_INVALID_PARAMETER;
 		goto out;
 	}
-
 	ret = tcg2_platform_get_tpm2(&dev);
 	if (ret != EFI_SUCCESS)
 		goto out;
 
-	EFI_ENTRY("%p, %p", this, active_pcr_banks);
 	ret = tcg2_get_active_pcr_banks(dev, active_pcr_banks);
 
 out:
-- 
2.39.3


  parent reply	other threads:[~2023-10-12 15:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 14:45 [PATCH v12 0/8] tpm: Support boot measurements Eddie James
2023-10-12 14:45 ` [PATCH v12 1/8] tpm: Fix spelling for tpmu_ha union Eddie James
2023-10-12 14:45 ` [PATCH v12 2/8] tpm: sandbox: Update for needed TPM2 capabilities Eddie James
2023-10-12 14:45 ` [PATCH v12 3/8] tpm: Support boot measurements Eddie James
2023-10-12 14:45 ` [PATCH v12 4/8] bootm: Support boot measurement Eddie James
2023-10-12 14:45 ` [PATCH v12 5/8] test: Add sandbox TPM " Eddie James
2023-10-13 17:22   ` Ilias Apalodimas
2023-10-19 13:29     ` Eddie James
2023-10-19 13:33       ` Ilias Apalodimas
2023-10-12 14:45 ` [PATCH v12 6/8] doc: Add measured boot documentation Eddie James
2023-10-12 15:29   ` Simon Glass
2023-10-19 16:13     ` Eddie James
2023-10-12 14:45 ` Eddie James [this message]
2023-10-12 14:45 ` [PATCH v12 8/8] test: use a non system PCR for testing PCR extend Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012144551.679551-8-eajames@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox