Re: [PATCH 06/11] board: ti: introduce basic board files for the am62px family

Tom Rini
2023-10-13T12:50:46Z

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

On Thu, Oct 12, 2023 at 06:06:23PM -0500, Bryan Brattlof wrote:

> Introduce the basic files needed to support the am62px family of SoCs
>
> Co-developed-by: Hari Hagalla <hnagalla@ti.com>
> Signed-off-by: Hari Hagalla <hnagalla@ti.com>
> Signed-off-by: Bryan Brattlof <bb@ti.com>
[snip]
> diff --git a/board/ti/am62px/evm.c b/board/ti/am62px/evm.c
> new file mode 100644
> index 0000000000000..44793cbed6536
> --- /dev/null
> +++ b/board/ti/am62px/evm.c
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Board specific initialization for AM62Px platforms
> + *
> + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/
> + *
> + */
> +
> +#include <asm/arch/hardware.h>
> +#include <asm/io.h>
> +#include <common.h>
> +#include <dm/uclass.h>
> +#include <env.h>
> +#include <fdt_support.h>
> +#include <spl.h>
> +
> +int board_init(void)
> +{
> + return 0;
> +}
> +
> +int dram_init(void)
> +{
> + return fdtdec_setup_mem_size_base();
> +}
> +
> +int dram_init_banksize(void)
> +{
> + return fdtdec_setup_memory_banksize();
> +}

Similar to what I said about another platform yesterday, lets split this
up in to "base.c" and "evm.c". The good news is that so far, I think
all of this should just be in base.c instead. Second, here and
elsewhere don't add common.h but instead add what you need. And
finally, for all of the new files please audit what headers you're
adding. 7 headers for 5 function prototypes is a bit much. Thanks.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]