public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg
@ 2023-10-04 19:13 Francesco Dolcini
  2023-10-04 21:23 ` Marcel Ziswiler
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Francesco Dolcini @ 2023-10-04 19:13 UTC (permalink / raw)
  To: Marcel Ziswiler
  Cc: Joao Paulo Goncalves, u-boot, Stefano Babic, Fabio Estevam,
	Francesco Dolcini

From: Joao Paulo Goncalves <joao.goncalves@toradex.com>

The bootcmd_mfg env variable is legacy from IMX downstream u-boot branch
and is not needed on mainline.

Signed-off-by: Joao Paulo Goncalves <joao.goncalves@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 include/configs/verdin-imx8mm.h | 1 -
 include/configs/verdin-imx8mp.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
index 8cb1f1aff353..8072d5d503f2 100644
--- a/include/configs/verdin-imx8mm.h
+++ b/include/configs/verdin-imx8mm.h
@@ -37,7 +37,6 @@
 #define CFG_EXTRA_ENV_SETTINGS \
 	BOOTENV \
 	MEM_LAYOUT_ENV_SETTINGS \
-	"bootcmd_mfg=fastboot 0\0" \
 	"boot_file=Image\0" \
 	"boot_script_dhcp=boot.scr\0" \
 	"console=ttymxc0\0" \
diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
index 942081ab84d7..5a34f6a9b205 100644
--- a/include/configs/verdin-imx8mp.h
+++ b/include/configs/verdin-imx8mp.h
@@ -46,7 +46,6 @@
 #define CFG_EXTRA_ENV_SETTINGS \
 	BOOTENV \
 	MEM_LAYOUT_ENV_SETTINGS \
-	"bootcmd_mfg=fastboot 0\0" \
 	"boot_file=Image\0" \
 	"boot_scripts=" BOOT_SCRIPT "\0" \
 	"boot_script_dhcp=" BOOT_SCRIPT "\0" \
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg
  2023-10-04 19:13 [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg Francesco Dolcini
@ 2023-10-04 21:23 ` Marcel Ziswiler
  2023-10-07 12:52 ` Fabio Estevam
  2023-10-16  9:22 ` sbabic
  2 siblings, 0 replies; 4+ messages in thread
From: Marcel Ziswiler @ 2023-10-04 21:23 UTC (permalink / raw)
  To: francesco@dolcini.it
  Cc: João Paulo Silva Gonçalves, u-boot@lists.denx.de,
	sbabic@denx.de, Francesco Dolcini, festevam@gmail.com

On Wed, 2023-10-04 at 16:13 -0300, Francesco Dolcini wrote:
> From: Joao Paulo Goncalves <joao.goncalves@toradex.com>
> 
> The bootcmd_mfg env variable is legacy from IMX downstream u-boot branch
> and is not needed on mainline.
> 
> Signed-off-by: Joao Paulo Goncalves <joao.goncalves@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  include/configs/verdin-imx8mm.h | 1 -
>  include/configs/verdin-imx8mp.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/include/configs/verdin-imx8mm.h b/include/configs/verdin-imx8mm.h
> index 8cb1f1aff353..8072d5d503f2 100644
> --- a/include/configs/verdin-imx8mm.h
> +++ b/include/configs/verdin-imx8mm.h
> @@ -37,7 +37,6 @@
>  #define CFG_EXTRA_ENV_SETTINGS \
>  	BOOTENV \
>  	MEM_LAYOUT_ENV_SETTINGS \
> -	"bootcmd_mfg=fastboot 0\0" \
>  	"boot_file=Image\0" \
>  	"boot_script_dhcp=boot.scr\0" \
>  	"console=ttymxc0\0" \
> diff --git a/include/configs/verdin-imx8mp.h b/include/configs/verdin-imx8mp.h
> index 942081ab84d7..5a34f6a9b205 100644
> --- a/include/configs/verdin-imx8mp.h
> +++ b/include/configs/verdin-imx8mp.h
> @@ -46,7 +46,6 @@
>  #define CFG_EXTRA_ENV_SETTINGS \
>  	BOOTENV \
>  	MEM_LAYOUT_ENV_SETTINGS \
> -	"bootcmd_mfg=fastboot 0\0" \
>  	"boot_file=Image\0" \
>  	"boot_scripts=" BOOT_SCRIPT "\0" \
>  	"boot_script_dhcp=" BOOT_SCRIPT "\0" \

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg
  2023-10-04 19:13 [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg Francesco Dolcini
  2023-10-04 21:23 ` Marcel Ziswiler
@ 2023-10-07 12:52 ` Fabio Estevam
  2023-10-16  9:22 ` sbabic
  2 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-10-07 12:52 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: Marcel Ziswiler, Joao Paulo Goncalves, u-boot, Stefano Babic,
	Francesco Dolcini

On Wed, Oct 4, 2023 at 4:14 PM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Joao Paulo Goncalves <joao.goncalves@toradex.com>
>
> The bootcmd_mfg env variable is legacy from IMX downstream u-boot branch
> and is not needed on mainline.
>
> Signed-off-by: Joao Paulo Goncalves <joao.goncalves@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg
  2023-10-04 19:13 [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg Francesco Dolcini
  2023-10-04 21:23 ` Marcel Ziswiler
  2023-10-07 12:52 ` Fabio Estevam
@ 2023-10-16  9:22 ` sbabic
  2 siblings, 0 replies; 4+ messages in thread
From: sbabic @ 2023-10-16  9:22 UTC (permalink / raw)
  To: Francesco Dolcini, u-boot

> From: Joao Paulo Goncalves <joao.goncalves@toradex.com>
> The bootcmd_mfg env variable is legacy from IMX downstream u-boot branch
> and is not needed on mainline.
> Signed-off-by: Joao Paulo Goncalves <joao.goncalves@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-10-16  9:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-04 19:13 [PATCH] toradex: verdin-imx8mm/imx8mp: Remove bootcmd_mfg Francesco Dolcini
2023-10-04 21:23 ` Marcel Ziswiler
2023-10-07 12:52 ` Fabio Estevam
2023-10-16  9:22 ` sbabic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox