* [PATCH] cros_ec: spi: disable annoying key echo on console
@ 2023-10-17 19:25 Milan P. Stanić
2023-10-18 3:33 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Milan P. Stanić @ 2023-10-17 19:25 UTC (permalink / raw)
To: u-boot; +Cc: Simon Glass, Milan P . Stanić
on Peach-pi console every key press is echoed with message
'cros_ec_command: Returned status 1'
this is not proper fix, just hack to disable this message
---
drivers/misc/cros_ec_spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c
index 001f0a85ca..7317f4b0f1 100644
--- a/drivers/misc/cros_ec_spi.c
+++ b/drivers/misc/cros_ec_spi.c
@@ -151,7 +151,6 @@ int cros_ec_spi_command(struct udevice *udev, uint8_t cmd, int cmd_version,
/* Response code is first byte of message */
if (p[0] != EC_RES_SUCCESS) {
- printf("%s: Returned status %d\n", __func__, p[0]);
return -(int)(p[0]);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cros_ec: spi: disable annoying key echo on console
2023-10-17 19:25 [PATCH] cros_ec: spi: disable annoying key echo on console Milan P. Stanić
@ 2023-10-18 3:33 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2023-10-18 3:33 UTC (permalink / raw)
To: mps; +Cc: u-boot
On Tue, 17 Oct 2023 at 13:25, Milan P. Stanić <mps@arvanta.net> wrote:
>
> on Peach-pi console every key press is echoed with message
> 'cros_ec_command: Returned status 1'
>
> this is not proper fix, just hack to disable this message
> ---
> drivers/misc/cros_ec_spi.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
I thought a similar patch went in ages ago but I now see it was in cros_ec_i2c.c
>
> diff --git a/drivers/misc/cros_ec_spi.c b/drivers/misc/cros_ec_spi.c
> index 001f0a85ca..7317f4b0f1 100644
> --- a/drivers/misc/cros_ec_spi.c
> +++ b/drivers/misc/cros_ec_spi.c
> @@ -151,7 +151,6 @@ int cros_ec_spi_command(struct udevice *udev, uint8_t cmd, int cmd_version,
>
> /* Response code is first byte of message */
> if (p[0] != EC_RES_SUCCESS) {
> - printf("%s: Returned status %d\n", __func__, p[0]);
log_debug() (without the __func__) would be better
> return -(int)(p[0]);
> }
>
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 3:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 19:25 [PATCH] cros_ec: spi: disable annoying key echo on console Milan P. Stanić
2023-10-18 3:33 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox