Re: [PATCH v3 02/32] bootstd: Correct dependencies on CMDLINE

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On Mon, Oct 16, 2023 at 04:27:53PM -0600, Simon Glass wrote:
> With recent changes over the last few years in boot/Kconfig it is
> no-longer possible to disable CMDLINE. It results in various link
> errors because some options which require CMDLINE are enabled
> regardless of whether it is available.
> 
> Add the necessary conditions to fix this.
> 
> Note that it would be better to have all commands depend on CMDLINE,
> but that is extremely difficult at present, since some functions use
> CMD_xxx to enable feature xxx. For example networking and environment
> have a number of problems to tease apart.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> 
> Changes in v3:
> - Reword commit message slightly
> 
>  boot/Kconfig           | 19 ++++++++++++-------
>  lib/efi_loader/Kconfig |  1 +
>  2 files changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/boot/Kconfig b/boot/Kconfig
> index a01e6cb8aafe..f74ac7e9cc72 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -342,6 +342,7 @@ endif # FIT
>  
>  config PXE_UTILS
>  	bool
> +	depends on CMDLINE
>  	select MENU
>  	help
>  	  Utilities for parsing PXE file formats.

So, this part here is because of CONFIG_SYS_PBSIZE, which I think we can
/ should solve another way.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]