* [PATCH] net: eth-uclass: Improve error message when MAC is not found
@ 2023-10-19 21:57 Fabio Estevam
2023-10-20 6:57 ` Lothar Waßmann
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-10-19 21:57 UTC (permalink / raw)
To: joe.hershberger; +Cc: rfried.dev, u-boot, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
While bringinp up a new board without the MAC fuses programmed,
the following error message was observed:
Error: ethernet@30bf0000 address not set.
Improve the error message to make it clearer the reason of
the failure.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
net/eth-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 4311f3fe6e89..1f0985ec52ca 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@ static int eth_post_probe(struct udevice *dev)
eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
pdata->enetaddr);
#else
- printf("\nError: %s address not set.\n",
+ printf("\nError: %s a valid MAC address was not found.\n",
dev->name);
return -EINVAL;
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: eth-uclass: Improve error message when MAC is not found
2023-10-19 21:57 [PATCH] net: eth-uclass: Improve error message when MAC is not found Fabio Estevam
@ 2023-10-20 6:57 ` Lothar Waßmann
0 siblings, 0 replies; 2+ messages in thread
From: Lothar Waßmann @ 2023-10-20 6:57 UTC (permalink / raw)
To: Fabio Estevam; +Cc: joe.hershberger, rfried.dev, u-boot, Fabio Estevam
Hi,
On Thu, 19 Oct 2023 18:57:20 -0300 Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> While bringinp up a new board without the MAC fuses programmed,
> the following error message was observed:
>
> Error: ethernet@30bf0000 address not set.
>
> Improve the error message to make it clearer the reason of
> the failure.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> net/eth-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index 4311f3fe6e89..1f0985ec52ca 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -594,7 +594,7 @@ static int eth_post_probe(struct udevice *dev)
> eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
> pdata->enetaddr);
> #else
> - printf("\nError: %s address not set.\n",
> + printf("\nError: %s a valid MAC address was not found.\n",
>
printf("\nError: %s No valid MAC address found.\n",
Lothar Waßmann
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-20 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-19 21:57 [PATCH] net: eth-uclass: Improve error message when MAC is not found Fabio Estevam
2023-10-20 6:57 ` Lothar Waßmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox