From: Fabio Estevam <festevam@gmail.com>
To: joe.hershberger@ni.com
Cc: rfried.dev@gmail.com, LW@karo-electronics.de,
u-boot@lists.denx.de, Fabio Estevam <festevam@denx.de>
Subject: [PATCH v2] net: eth-uclass: Improve error message when MAC is not found
Date: Fri, 20 Oct 2023 09:41:51 -0300 [thread overview]
Message-ID: <20231020124151.1968187-1-festevam@gmail.com> (raw)
From: Fabio Estevam <festevam@denx.de>
While bringinp up a new board without the MAC fuses programmed,
the following error message was observed:
Error: ethernet@30bf0000 address not set.
Improve the error message to make it clearer the reason of
the failure.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reword the error message. (Lothar)
net/eth-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 4311f3fe6e89..1f0985ec52ca 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@ static int eth_post_probe(struct udevice *dev)
eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
pdata->enetaddr);
#else
- printf("\nError: %s address not set.\n",
+ printf("\nError: %s No valid MAC address found.\n",
dev->name);
return -EINVAL;
#endif
--
2.34.1
next reply other threads:[~2023-10-20 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 12:41 Fabio Estevam [this message]
2023-11-06 16:32 ` [PATCH v2] net: eth-uclass: Improve error message when MAC is not found Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020124151.1968187-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=LW@karo-electronics.de \
--cc=festevam@denx.de \
--cc=joe.hershberger@ni.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox