[PATCH v2] net: eth-uclass: Improve error message when MAC is not found

[PATCH v2] net: eth-uclass: Improve error message when MAC is not found

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

While bringinp up a new board without the MAC fuses programmed,
the following error message was observed:

Error: ethernet@30bf0000 address not set.

Improve the error message to make it clearer the reason of
the failure.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reword the error message. (Lothar)

 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 4311f3fe6e89..1f0985ec52ca 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@ static int eth_post_probe(struct udevice *dev)
 		eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
 					      pdata->enetaddr);
 #else
-		printf("\nError: %s address not set.\n",
+		printf("\nError: %s No valid MAC address found.\n",
 		       dev->name);
 		return -EINVAL;
 #endif
-- 
2.34.1

Re: [PATCH v2] net: eth-uclass: Improve error message when MAC is not found

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Fri, Oct 20, 2023 at 09:41:51AM -0300, Fabio Estevam wrote:

> From: Fabio Estevam <festevam@denx.de>
> 
> While bringinp up a new board without the MAC fuses programmed,
> the following error message was observed:
> 
> Error: ethernet@30bf0000 address not set.
> 
> Improve the error message to make it clearer the reason of
> the failure.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]