From: Tom Rini <trini@konsulko.com>
To: Yurii Monakov <monakov.y@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v3] cli: Consume invalid escape sequences early
Date: Tue, 24 Oct 2023 19:16:44 -0400 [thread overview]
Message-ID: <20231024231644.GA496310@bill-the-cat> (raw)
In-Reply-To: <775fa336fa5bfb2b9e1e892ee631bd743ea12364.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On Tue, Oct 10, 2023 at 11:16:39AM +0300, Yurii Monakov wrote:
> Unexpected 'Esc' key presses are accumulated internally, even if it is
> already clear that the current escape sequence is invalid. This results
> in weird behaviour. For example, the next character after 'Esc' key
> simply disappears from input and 'Unknown command' is printed
> after 'Enter'.
>
> This commit fixes some issues with extra 'Esc' keys entered by user:
>
> 1. Sequence <Esc><Esc><Enter> right after autoboot stop gives:
> =>
> nknown command 'ry 'help'
> =>
> 2. Sequence <Esc><p><r><i><Enter> gives:
> => ri
> Unknown command 'ri' - try 'help'
> =>
> 3. Extra 'Esc' key presses break backspace functionality.
>
> Signed-off-by: Yurii Monakov <monakov.y@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-10-24 23:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 8:16 [PATCH v3] cli: Consume invalid escape sequences early Yurii Monakov
2023-10-10 14:57 ` Simon Glass
2023-10-10 16:19 ` Yurii Monakov
2023-10-24 23:16 ` Tom Rini [this message]
2023-10-25 8:31 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024231644.GA496310@bill-the-cat \
--to=trini@konsulko.com \
--cc=monakov.y@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox