From: Tom Rini <trini@konsulko.com>
To: seanedmond@linux.microsoft.com
Cc: u-boot@lists.denx.de, sjg@chromium.org,
dphadke@linux.microsoft.com, ilias.apalodimas@linaro.org
Subject: Re: [PATCH v3 4/5] dm: core: Modify default for OFNODE_MULTI_TREE
Date: Thu, 2 Nov 2023 18:06:18 -0400 [thread overview]
Message-ID: <20231102220618.GA2106979@bill-the-cat> (raw)
In-Reply-To: <20230912213504.65513-5-seanedmond@linux.microsoft.com>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
On Tue, Sep 12, 2023 at 02:35:03PM -0700, seanedmond@linux.microsoft.com wrote:
> From: Sean Edmond <seanedmond@microsoft.com>
>
> There is a preference to use the "ofnode" API for FDT fixups
> moving forward. The FDT fixup will usually be for the kernel FDT. To
> fixup the kernel FDT with the ofnode API, it's required to set the
> OFNODE_MULTI_TREE option.
>
> To ensure existing users of kaslr fdt fixup are not impacted, Let's modify
> the default value for OFNODE_MULTI_TREE to ensure it's always set if
> !OF_LIVE. This will cause a 1007 byte increase in the code size.
>
> Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> drivers/core/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This leads to failure to build such as:
Building current source for 1 boards (1 thread, 12 jobs per thread)
arm: + integratorap_cm946es
+(integratorap_cm946es) arm-linux-gnueabi-ld.bfd: common/board_r.o: in function `initr_dm':
+(integratorap_cm946es) common/board_r.c:231:(.text.initr_dm+0x4): undefined reference to `oftree_reset'
+(integratorap_cm946es) make[1]: *** [Makefile:1765: u-boot] Error 1
+(integratorap_cm946es) make: *** [Makefile:177: sub-make] Error 2
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-11-02 22:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 21:34 [PATCH v3 0/5] Populate kaslr seed with RNG seanedmond
2023-09-12 21:35 ` [PATCH v3 1/5] fdt: common API to populate kaslr seed seanedmond
2023-09-21 1:02 ` Simon Glass
2023-09-12 21:35 ` [PATCH v3 2/5] fdt: kaslr seed from RNG device seanedmond
2023-09-21 1:02 ` Simon Glass
2023-09-12 21:35 ` [PATCH v3 3/5] cmd: kaslrseed: Use common API to fixup FDT seanedmond
2023-09-21 1:02 ` Simon Glass
2023-09-12 21:35 ` [PATCH v3 4/5] dm: core: Modify default for OFNODE_MULTI_TREE seanedmond
2023-09-21 1:03 ` Simon Glass
2023-11-02 22:06 ` Tom Rini [this message]
2023-09-12 21:35 ` [PATCH v3 5/5] fdt: Fix compile error for !OFNODE_MULTI_TREE seanedmond
2023-09-21 1:03 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231102220618.GA2106979@bill-the-cat \
--to=trini@konsulko.com \
--cc=dphadke@linux.microsoft.com \
--cc=ilias.apalodimas@linaro.org \
--cc=seanedmond@linux.microsoft.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox