[PATCH] pico-imx7d: Remove board_phy_config()

[PATCH] pico-imx7d: Remove board_phy_config()

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

With Ethernet DM in place, there is no longer the need for having
the board_phy_config() anymore.

Remove it.

Tested on imx7d-pico-pi board:

=> setenv autoload no
=> dhcp
BOOTP broadcast 1
*** Unhandled DHCP Option in OFFER/ACK: 42
DHCP client bound to address 192.168.0.138 (138 ms)
=> tftp zImage
Using ethernet@30be0000 device
TFTP from server 192.168.0.16; our IP address is 192.168.0.138
Filename 'zImage'.
Load address: 0x80800000
Loading: #################################################################
....
	 #################################################################
	 ##########
	 4.3 MiB/s
done
Bytes transferred = 9034120 (89d988 hex)

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 board/technexion/pico-imx7d/pico-imx7d.c | 26 ------------------------
 1 file changed, 26 deletions(-)

diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
index 6e98b85b2873..5def6eda43e5 100644
--- a/board/technexion/pico-imx7d/pico-imx7d.c
+++ b/board/technexion/pico-imx7d/pico-imx7d.c
@@ -101,32 +101,6 @@ static int setup_fec(void)
 
 	return set_clk_enet(ENET_125MHZ);
 }
-
-int board_phy_config(struct phy_device *phydev)
-{
-	unsigned short val;
-
-	/* To enable AR8035 ouput a 125MHz clk from CLK_25M */
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
-
-	val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
-	val &= 0xffe7;
-	val |= 0x18;
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
-
-	/* introduce tx clock delay */
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
-	val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
-	val |= 0x0100;
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
-
-	if (phydev->drv->config)
-		phydev->drv->config(phydev);
-
-	return 0;
-}
 #endif
 
 static void setup_iomux_uart(void)
-- 
2.34.1

Re: [PATCH] pico-imx7d: Remove board_phy_config()

[Szőke Kálmán Benjamin]

Other pico SoMs still has board_phy_config() also, you should remove it from them, too.pico-imx8mq: https://github.com/u-boot/u-boot/blob/master/board/technexion/pico-imx8mq/pico-imx8mq.c#L111pico-imx6ul: https://github.com/u-boot/u-boot/blob/master/board/technexion/pico-imx6ul/pico-imx6ul.c#L110pico-imx6: https://github.com/u-boot/u-boot/blob/master/board/technexion/pico-imx6/pico-imx6.c#L314

Re: [PATCH] pico-imx7d: Remove board_phy_config()

[Fabio Estevam]

On Sat, Nov 4, 2023 at 7:45 AM Szőke Kálmán Benjamin
<egyszeregy@freemail.hu> wrote:
>
> Other pico SoMs still has board_phy_config() also, you should remove it from them, too.

board_phy_config() could probably be removed from these boards too.

To be sure, someone has to test it. If there is a problem with the
devicetree description, simply removing
board_phy_config() may cause an Ethernet regression.

If you have access to these boards, feel free to test and submit patches.

Re: [PATCH] pico-imx7d: Remove board_phy_config()

[Fabio Estevam]

On Fri, Nov 3, 2023 at 7:47 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> With Ethernet DM in place, there is no longer the need for having
> the board_phy_config() anymore.
>
> Remove it.
>
> Tested on imx7d-pico-pi board:
>
> => setenv autoload no
> => dhcp
> BOOTP broadcast 1
> *** Unhandled DHCP Option in OFFER/ACK: 42
> DHCP client bound to address 192.168.0.138 (138 ms)
> => tftp zImage
> Using ethernet@30be0000 device
> TFTP from server 192.168.0.16; our IP address is 192.168.0.138
> Filename 'zImage'.
> Load address: 0x80800000
> Loading: #################################################################
> ....
>          #################################################################
>          ##########
>          4.3 MiB/s
> done
> Bytes transferred = 9034120 (89d988 hex)
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to u-boot-imx next, thanks.