public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Tom Rini <trini@konsulko.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Sinthu Raja <sinthu.raja@ti.com>,
	Manorit Chawdhry <m-chawdhry@ti.com>, Reid Tonking <reidt@ti.com>,
	Neha Malcom Francis <n-francis@ti.com>, Andrew Davis <afd@ti.com>,
	Simon Glass <sjg@chromium.org>,
	Robert Nelson <robertcnelson@gmail.com>,
	Jason Kridner <jkridner@beagleboard.org>,
	Nishanth Menon <nm@ti.com>, <u-boot@lists.denx.de>
Subject: [PATCH V2 02/12] board: ti: j721e: evm: Drop board check for ESM
Date: Sat, 4 Nov 2023 02:21:40 -0500	[thread overview]
Message-ID: <20231104072150.3339-3-nm@ti.com> (raw)
In-Reply-To: <20231104072150.3339-1-nm@ti.com>

When config is enabled, the esm dt probe makes sense. Simplify by
dropping board specific checks.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 board/ti/j721e/evm.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c
index aa22f1653fec..8f0996c32ee6 100644
--- a/board/ti/j721e/evm.c
+++ b/board/ti/j721e/evm.c
@@ -523,10 +523,8 @@ err_free_gpio:
 
 void spl_board_init(void)
 {
-#if defined(CONFIG_ESM_K3) || defined(CONFIG_ESM_PMIC)
 	struct udevice *dev;
 	int ret;
-#endif
 
 	if ((IS_ENABLED(CONFIG_TARGET_J721E_A72_EVM) ||
 	     IS_ENABLED(CONFIG_TARGET_J7200_A72_EVM)) &&
@@ -535,24 +533,20 @@ void spl_board_init(void)
 			probe_daughtercards();
 	}
 
-#ifdef CONFIG_ESM_K3
-	if (board_ti_k3_is("J721EX-PM2-SOM")) {
+	if (IS_ENABLED(CONFIG_ESM_K3)) {
 		ret = uclass_get_device_by_driver(UCLASS_MISC,
 						  DM_DRIVER_GET(k3_esm), &dev);
 		if (ret)
 			printf("ESM init failed: %d\n", ret);
 	}
-#endif
 
-#ifdef CONFIG_ESM_PMIC
-	if (board_ti_k3_is("J721EX-PM2-SOM")) {
+	if (IS_ENABLED(CONFIG_ESM_PMIC)) {
 		ret = uclass_get_device_by_driver(UCLASS_MISC,
 						  DM_DRIVER_GET(pmic_esm),
 						  &dev);
 		if (ret)
 			printf("ESM PMIC init failed: %d\n", ret);
 	}
-#endif
 	if ((IS_ENABLED(CONFIG_TARGET_J7200_A72_EVM) || IS_ENABLED(CONFIG_TARGET_J721E_A72_EVM)) &&
 	    IS_ENABLED(CONFIG_HBMC_AM654)) {
 		struct udevice *dev;
-- 
2.37.2


  parent reply	other threads:[~2023-11-04  7:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-04  7:21 [PATCH V2 00/12] board: ti: j721e: cleanup Nishanth Menon
2023-11-04  7:21 ` [PATCH V2 01/12] board: ti: j721e: evm: Drop unused headers Nishanth Menon
2023-11-07  7:02   ` Neha Malcom Francis
2023-11-22 20:49   ` Tom Rini
2023-11-04  7:21 ` Nishanth Menon [this message]
2023-11-07  7:06   ` [PATCH V2 02/12] board: ti: j721e: evm: Drop board check for ESM Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 03/12] board: ti: j721e: evm: Switch to using IS_ENABLED Nishanth Menon
2023-11-07  7:08   ` Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 04/12] board: ti: j721e: j721e.env: Add explicit boot_targets Nishanth Menon
2023-11-07  7:09   ` Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 05/12] configs: j721e_evm_a72_defconfig: Switch to bootstd Nishanth Menon
2023-11-07  7:09   ` Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 06/12] arm: mach-k3: Kconfig: Introduce a symbol to indicate J7200 Nishanth Menon
2023-11-06 16:45   ` Andrew Davis
2023-11-06 16:50     ` Nishanth Menon
2023-11-04  7:21 ` [PATCH V2 07/12] board: ti: j721e: Select SOC_K3_J721E_J7200 for J7200evm Nishanth Menon
2023-11-04  7:21 ` [PATCH V2 08/12] arm: mach-k3: arm64-mmu: Refactor to be independent of board Nishanth Menon
2023-11-06 16:54   ` Andrew Davis
2023-11-04  7:21 ` [PATCH V2 09/12] arm: mach-k3: j721e: Improve support for UDA FS Nishanth Menon
2023-11-04  7:21 ` [PATCH V2 10/12] configs: j7200: Remove HBMC_AM654 config Nishanth Menon
2023-11-07  7:11   ` Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 11/12] configs: j7200_evm_a72_defconfig: Switch to bootstd Nishanth Menon
2023-11-07  7:12   ` Neha Malcom Francis
2023-11-04  7:21 ` [PATCH V2 12/12] doc: board: ti: j721e_evm: Use board relative path for include directives Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231104072150.3339-3-nm@ti.com \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=jkridner@beagleboard.org \
    --cc=m-chawdhry@ti.com \
    --cc=n-francis@ti.com \
    --cc=reidt@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=sinthu.raja@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox