public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: "Simon Glass" <sjg@chromium.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Marek Behún" <marek.behun@nic.cz>, "Marek Vasut" <marex@denx.de>,
	"Xavier Drudis Ferran" <xdrudis@tinet.cat>,
	"Stefan Roese" <sr@denx.de>, "Pali Rohár" <pali@kernel.org>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Joe Hershberger" <joe.hershberger@ni.com>,
	"Ramon Fried" <rfried.dev@gmail.com>
Subject: [PATCH v6 19/25] spl: Convert net to spl_load
Date: Sun,  5 Nov 2023 21:25:57 -0500	[thread overview]
Message-ID: <20231106022603.3405551-20-seanga2@gmail.com> (raw)
In-Reply-To: <20231106022603.3405551-1-seanga2@gmail.com>

This converts the net load method to use spl_load. As a result, it also
adds support for LOAD_FIT_FULL and IMX images.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

Changes in v6:
- Explicitly initialize load_info members

Changes in v5:
- Rework to load header in spl_load

 common/spl/spl_net.c      | 29 +++++------------------------
 include/spl_load.h        |  1 +
 test/image/spl_load_net.c |  2 ++
 3 files changed, 8 insertions(+), 24 deletions(-)

diff --git a/common/spl/spl_net.c b/common/spl/spl_net.c
index 47994e28165..898f9df705a 100644
--- a/common/spl/spl_net.c
+++ b/common/spl/spl_net.c
@@ -11,8 +11,8 @@
 #include <errno.h>
 #include <image.h>
 #include <log.h>
-#include <mapmem.h>
 #include <spl.h>
+#include <spl_load.h>
 #include <net.h>
 #include <linux/libfdt.h>
 
@@ -29,8 +29,7 @@ static ulong spl_net_load_read(struct spl_load_info *load, ulong sector,
 static int spl_net_load_image(struct spl_image_info *spl_image,
 			      struct spl_boot_device *bootdev)
 {
-	struct legacy_img_hdr *header = map_sysmem(image_load_addr,
-						   sizeof(*header));
+	struct spl_load_info load;
 	int rv;
 
 	env_init();
@@ -49,27 +48,9 @@ static int spl_net_load_image(struct spl_image_info *spl_image,
 		return rv;
 	}
 
-	if (IS_ENABLED(CONFIG_SPL_LOAD_FIT) &&
-	    image_get_magic(header) == FDT_MAGIC) {
-		struct spl_load_info load;
-
-		debug("Found FIT\n");
-		spl_set_bl_len(&load, 1);
-		load.read = spl_net_load_read;
-		rv = spl_load_simple_fit(spl_image, &load, 0, header);
-	} else {
-		debug("Legacy image\n");
-
-		rv = spl_parse_image_header(spl_image, bootdev, header);
-		if (rv)
-			return rv;
-
-		memcpy(map_sysmem(spl_image->load_addr, spl_image->size),
-		       map_sysmem(image_load_addr, spl_image->size),
-		       spl_image->size);
-	}
-
-	return rv;
+	spl_set_bl_len(&load, 1);
+	load.read = spl_net_load_read;
+	return spl_load(spl_image, bootdev, &load, 0, 0);
 }
 #endif
 
diff --git a/include/spl_load.h b/include/spl_load.h
index 38294a21ad0..4777f84ac6b 100644
--- a/include/spl_load.h
+++ b/include/spl_load.h
@@ -99,6 +99,7 @@ static inline int _spl_load(struct spl_image_info *spl_image,
 	IS_ENABLED(CONFIG_SPL_FS_FAT) + \
 	IS_ENABLED(CONFIG_SPL_SYS_MMCSD_RAW_MODE) + \
 	(IS_ENABLED(CONFIG_SPL_NAND_SUPPORT) && !IS_ENABLED(CONFIG_SPL_UBI)) + \
+	IS_ENABLED(CONFIG_SPL_NET) + \
 	0
 
 #if SPL_LOAD_USERS > 1
diff --git a/test/image/spl_load_net.c b/test/image/spl_load_net.c
index f570cef163f..9d067a7a592 100644
--- a/test/image/spl_load_net.c
+++ b/test/image/spl_load_net.c
@@ -248,5 +248,7 @@ static int spl_test_net(struct unit_test_state *uts, const char *test_name,
 	return ret;
 }
 SPL_IMG_TEST(spl_test_net, LEGACY, DM_FLAGS);
+SPL_IMG_TEST(spl_test_net, LEGACY_LZMA, DM_FLAGS);
+SPL_IMG_TEST(spl_test_net, IMX8, DM_FLAGS);
 SPL_IMG_TEST(spl_test_net, FIT_INTERNAL, DM_FLAGS);
 SPL_IMG_TEST(spl_test_net, FIT_EXTERNAL, DM_FLAGS);
-- 
2.37.1


  parent reply	other threads:[~2023-11-06  3:07 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  2:25 [PATCH v6 00/25] spl: Use common function for loading/parsing images Sean Anderson
2023-11-06  2:25 ` [PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 02/25] arm: Disable SPL_FS_FAT when it isn't used Sean Anderson
2023-11-06  6:58   ` Michal Simek
2023-11-06  2:25 ` [PATCH v6 03/25] spl: Make SHOW_ERRORS depend on LIBCOMMON Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 04/25] spl: semihosting: Don't close fd before spl_load_simple_fit Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 05/25] spl: Remove NULL assignments in spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:30     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 06/25] spl: Remove dev from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 16:19     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 07/25] spl: Take advantage of bl_len's power-of-twoness Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes Sean Anderson
2023-11-06 12:35   ` Xavier Drudis Ferran
2023-11-06 13:54     ` Sean Anderson
2023-11-07  8:49       ` Xavier Drudis Ferran
2023-11-08 15:59         ` Sean Anderson
2023-11-09  6:24           ` Xavier Drudis Ferran
2023-11-06  2:25 ` [PATCH v6 09/25] spl: Remove filename from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:34     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 10/25] spl: Only support bl_len when we have to Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 11/25] spl: nand: Remove spl_nand_legacy_read Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 12/25] spl: legacy: Split off LZMA decompression into its own function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 13/25] test: spl: Support testing LEGACY_LZMA filesystem images Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 14/25] spl: Add generic spl_load function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 15/25] spl: Convert ext to use spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:37     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 16/25] spl: Convert fat to spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:49     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 17/25] spl: Convert mmc " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 18/25] spl: Convert nand " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` Sean Anderson [this message]
2023-11-08  4:24   ` [PATCH v6 19/25] spl: Convert net " Simon Glass
2023-11-06  2:25 ` [PATCH v6 20/25] spl: Convert nor " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 21/25] spl: Convert NVMe " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 22/25] spl: Convert semihosting " Sean Anderson
2023-11-06  2:26 ` [PATCH v6 23/25] spl: Convert spi " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 24/25] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 25/25] spl: fat: Add option to disable DMA alignment Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  7:49 ` [PATCH v6 00/25] spl: Use common function for loading/parsing images Pali Rohár
2023-11-06  9:18   ` Heinrich Schuchardt
2023-11-06 10:12   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231106022603.3405551-20-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=rfried.dev@gmail.com \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xdrudis@tinet.cat \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox