From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: "Simon Glass" <sjg@chromium.org>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Marek Behún" <marek.behun@nic.cz>, "Marek Vasut" <marex@denx.de>,
"Xavier Drudis Ferran" <xdrudis@tinet.cat>,
"Stefan Roese" <sr@denx.de>, "Pali Rohár" <pali@kernel.org>,
"Sean Anderson" <seanga2@gmail.com>
Subject: [PATCH v6 05/25] spl: Remove NULL assignments in spl_load_info
Date: Sun, 5 Nov 2023 21:25:43 -0500 [thread overview]
Message-ID: <20231106022603.3405551-6-seanga2@gmail.com> (raw)
In-Reply-To: <20231106022603.3405551-1-seanga2@gmail.com>
Remove NULL assignments to fields in spl_load_info when .load doesn't
reference these fields. This can result in more efficient code. filename
must stay even if it is unused, since load_simple_fit uses it.
Signed-off-by: Sean Anderson <seanga2@gmail.com>
---
Changes in v6:
- New
arch/arm/mach-sunxi/spl_spi_sunxi.c | 2 --
common/spl/spl_fat.c | 1 -
common/spl/spl_mmc.c | 2 --
common/spl/spl_nand.c | 4 ----
common/spl/spl_spi.c | 2 --
common/spl/spl_ymodem.c | 1 -
6 files changed, 12 deletions(-)
diff --git a/arch/arm/mach-sunxi/spl_spi_sunxi.c b/arch/arm/mach-sunxi/spl_spi_sunxi.c
index c2410dd7bb1..896aba69c32 100644
--- a/arch/arm/mach-sunxi/spl_spi_sunxi.c
+++ b/arch/arm/mach-sunxi/spl_spi_sunxi.c
@@ -354,8 +354,6 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
struct spl_load_info load;
debug("Found FIT image\n");
- load.dev = NULL;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = 1;
load.read = spi_load_read;
diff --git a/common/spl/spl_fat.c b/common/spl/spl_fat.c
index 014074f85be..6172e7bcd48 100644
--- a/common/spl/spl_fat.c
+++ b/common/spl/spl_fat.c
@@ -99,7 +99,6 @@ int spl_load_image_fat(struct spl_image_info *spl_image,
load.read = spl_fit_read;
load.bl_len = 1;
load.filename = (void *)filename;
- load.priv = NULL;
return spl_load_simple_fit(spl_image, &load, 0, header);
} else {
diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
index 82689da1401..6d9137c32e0 100644
--- a/common/spl/spl_mmc.c
+++ b/common/spl/spl_mmc.c
@@ -106,7 +106,6 @@ int mmc_load_image_raw_sector(struct spl_image_info *spl_image,
debug("Found FIT\n");
load.dev = mmc;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = mmc->read_bl_len;
load.read = h_spl_load_read;
@@ -116,7 +115,6 @@ int mmc_load_image_raw_sector(struct spl_image_info *spl_image,
struct spl_load_info load;
load.dev = mmc;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = mmc->read_bl_len;
load.read = h_spl_load_read;
diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c
index b8cd6403ba4..9a5a5ffa04a 100644
--- a/common/spl/spl_nand.c
+++ b/common/spl/spl_nand.c
@@ -91,7 +91,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
struct spl_load_info load;
debug("Found FIT\n");
- load.dev = NULL;
load.priv = &offset;
load.filename = NULL;
load.bl_len = bl_len;
@@ -101,7 +100,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
valid_container_hdr((void *)header)) {
struct spl_load_info load;
- load.dev = NULL;
load.priv = &offset;
load.filename = NULL;
load.bl_len = bl_len;
@@ -112,8 +110,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
struct spl_load_info load;
debug("Found legacy image\n");
- load.dev = NULL;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = IS_ENABLED(CONFIG_SPL_LZMA) ? bl_len : 1;
load.read = spl_nand_legacy_read;
diff --git a/common/spl/spl_spi.c b/common/spl/spl_spi.c
index 3ac4b1b5091..d83d70f2f33 100644
--- a/common/spl/spl_spi.c
+++ b/common/spl/spl_spi.c
@@ -152,7 +152,6 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
debug("Found FIT\n");
load.dev = flash;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = 1;
load.read = spl_spi_fit_read;
@@ -164,7 +163,6 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
struct spl_load_info load;
load.dev = flash;
- load.priv = NULL;
load.filename = NULL;
load.bl_len = 1;
load.read = spl_spi_fit_read;
diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c
index 038b4438457..8616cb3e915 100644
--- a/common/spl/spl_ymodem.c
+++ b/common/spl/spl_ymodem.c
@@ -134,7 +134,6 @@ int spl_ymodem_load_image(struct spl_image_info *spl_image,
struct ymodem_fit_info info;
debug("Found FIT\n");
- load.dev = NULL;
load.priv = (void *)&info;
load.filename = NULL;
load.bl_len = 1;
--
2.37.1
next prev parent reply other threads:[~2023-11-06 2:46 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 2:25 [PATCH v6 00/25] spl: Use common function for loading/parsing images Sean Anderson
2023-11-06 2:25 ` [PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 02/25] arm: Disable SPL_FS_FAT when it isn't used Sean Anderson
2023-11-06 6:58 ` Michal Simek
2023-11-06 2:25 ` [PATCH v6 03/25] spl: Make SHOW_ERRORS depend on LIBCOMMON Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 04/25] spl: semihosting: Don't close fd before spl_load_simple_fit Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` Sean Anderson [this message]
2023-11-08 4:23 ` [PATCH v6 05/25] spl: Remove NULL assignments in spl_load_info Simon Glass
2023-11-08 15:30 ` Sean Anderson
2023-11-06 2:25 ` [PATCH v6 06/25] spl: Remove dev from spl_load_info Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-08 16:19 ` Sean Anderson
2023-11-06 2:25 ` [PATCH v6 07/25] spl: Take advantage of bl_len's power-of-twoness Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes Sean Anderson
2023-11-06 12:35 ` Xavier Drudis Ferran
2023-11-06 13:54 ` Sean Anderson
2023-11-07 8:49 ` Xavier Drudis Ferran
2023-11-08 15:59 ` Sean Anderson
2023-11-09 6:24 ` Xavier Drudis Ferran
2023-11-06 2:25 ` [PATCH v6 09/25] spl: Remove filename from spl_load_info Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-08 15:34 ` Sean Anderson
2023-11-06 2:25 ` [PATCH v6 10/25] spl: Only support bl_len when we have to Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 11/25] spl: nand: Remove spl_nand_legacy_read Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 12/25] spl: legacy: Split off LZMA decompression into its own function Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 13/25] test: spl: Support testing LEGACY_LZMA filesystem images Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 14/25] spl: Add generic spl_load function Sean Anderson
2023-11-08 4:23 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 15/25] spl: Convert ext to use spl_load Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-08 15:37 ` Sean Anderson
2023-11-06 2:25 ` [PATCH v6 16/25] spl: Convert fat to spl_load Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-08 15:49 ` Sean Anderson
2023-11-06 2:25 ` [PATCH v6 17/25] spl: Convert mmc " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 18/25] spl: Convert nand " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 19/25] spl: Convert net " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 20/25] spl: Convert nor " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:25 ` [PATCH v6 21/25] spl: Convert NVMe " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:26 ` [PATCH v6 22/25] spl: Convert semihosting " Sean Anderson
2023-11-06 2:26 ` [PATCH v6 23/25] spl: Convert spi " Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:26 ` [PATCH v6 24/25] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 2:26 ` [PATCH v6 25/25] spl: fat: Add option to disable DMA alignment Sean Anderson
2023-11-08 4:24 ` Simon Glass
2023-11-06 7:49 ` [PATCH v6 00/25] spl: Use common function for loading/parsing images Pali Rohár
2023-11-06 9:18 ` Heinrich Schuchardt
2023-11-06 10:12 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106022603.3405551-6-seanga2@gmail.com \
--to=seanga2@gmail.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xdrudis@tinet.cat \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox