public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: "Simon Glass" <sjg@chromium.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Marek Behún" <marek.behun@nic.cz>, "Marek Vasut" <marex@denx.de>,
	"Xavier Drudis Ferran" <xdrudis@tinet.cat>,
	"Stefan Roese" <sr@denx.de>, "Pali Rohár" <pali@kernel.org>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Stefano Babic" <sbabic@denx.de>,
	uboot-imx@nxp.com
Subject: [PATCH v6 07/25] spl: Take advantage of bl_len's power-of-twoness
Date: Sun,  5 Nov 2023 21:25:45 -0500	[thread overview]
Message-ID: <20231106022603.3405551-8-seanga2@gmail.com> (raw)
In-Reply-To: <20231106022603.3405551-1-seanga2@gmail.com>

bl_len must be a power of two, so we can use ALIGN instead of roundup and
similar tricks to avoid divisions.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
---

Changes in v6:
- New

 common/spl/spl_fit.c           | 2 +-
 common/spl/spl_imx_container.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
index 70d8d5942d9..6084ead0919 100644
--- a/common/spl/spl_fit.c
+++ b/common/spl/spl_fit.c
@@ -194,7 +194,7 @@ static int get_aligned_image_overhead(struct spl_load_info *info, int offset)
 	if (info->filename)
 		return offset & (ARCH_DMA_MINALIGN - 1);
 
-	return offset % info->bl_len;
+	return offset & (info->bl_len - 1);
 }
 
 static int get_aligned_image_size(struct spl_load_info *info, int data_size,
diff --git a/common/spl/spl_imx_container.c b/common/spl/spl_imx_container.c
index 127802f5cb7..1cc51782766 100644
--- a/common/spl/spl_imx_container.c
+++ b/common/spl/spl_imx_container.c
@@ -33,13 +33,13 @@ static struct boot_img_t *read_auth_image(struct spl_image_info *spl_image,
 	images = (struct boot_img_t *)((u8 *)container +
 				       sizeof(struct container_hdr));
 
-	if (images[image_index].offset % info->bl_len) {
+	if (!IS_ALIGNED(images[image_index].offset, info->bl_len)) {
 		printf("%s: image%d offset not aligned to %u\n",
 		       __func__, image_index, info->bl_len);
 		return NULL;
 	}
 
-	sectors = roundup(images[image_index].size, info->bl_len) /
+	sectors = ALIGN(images[image_index].size, info->bl_len) /
 		info->bl_len;
 	sector = images[image_index].offset / info->bl_len +
 		container_sector;
@@ -69,7 +69,7 @@ static int read_auth_container(struct spl_image_info *spl_image,
 	u32 sectors;
 	int i, size, ret = 0;
 
-	size = roundup(CONTAINER_HDR_ALIGNMENT, info->bl_len);
+	size = ALIGN(CONTAINER_HDR_ALIGNMENT, info->bl_len);
 	sectors = size / info->bl_len;
 
 	/*
@@ -103,7 +103,7 @@ static int read_auth_container(struct spl_image_info *spl_image,
 	debug("Container length %u\n", length);
 
 	if (length > CONTAINER_HDR_ALIGNMENT) {
-		size = roundup(length, info->bl_len);
+		size = ALIGN(length, info->bl_len);
 		sectors = size / info->bl_len;
 
 		free(container);
-- 
2.37.1


  parent reply	other threads:[~2023-11-06  2:55 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06  2:25 [PATCH v6 00/25] spl: Use common function for loading/parsing images Sean Anderson
2023-11-06  2:25 ` [PATCH v6 01/25] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 02/25] arm: Disable SPL_FS_FAT when it isn't used Sean Anderson
2023-11-06  6:58   ` Michal Simek
2023-11-06  2:25 ` [PATCH v6 03/25] spl: Make SHOW_ERRORS depend on LIBCOMMON Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 04/25] spl: semihosting: Don't close fd before spl_load_simple_fit Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 05/25] spl: Remove NULL assignments in spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:30     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 06/25] spl: Remove dev from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 16:19     ` Sean Anderson
2023-11-06  2:25 ` Sean Anderson [this message]
2023-11-08  4:23   ` [PATCH v6 07/25] spl: Take advantage of bl_len's power-of-twoness Simon Glass
2023-11-06  2:25 ` [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes Sean Anderson
2023-11-06 12:35   ` Xavier Drudis Ferran
2023-11-06 13:54     ` Sean Anderson
2023-11-07  8:49       ` Xavier Drudis Ferran
2023-11-08 15:59         ` Sean Anderson
2023-11-09  6:24           ` Xavier Drudis Ferran
2023-11-06  2:25 ` [PATCH v6 09/25] spl: Remove filename from spl_load_info Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-08 15:34     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 10/25] spl: Only support bl_len when we have to Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 11/25] spl: nand: Remove spl_nand_legacy_read Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 12/25] spl: legacy: Split off LZMA decompression into its own function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 13/25] test: spl: Support testing LEGACY_LZMA filesystem images Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 14/25] spl: Add generic spl_load function Sean Anderson
2023-11-08  4:23   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 15/25] spl: Convert ext to use spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:37     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 16/25] spl: Convert fat to spl_load Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-08 15:49     ` Sean Anderson
2023-11-06  2:25 ` [PATCH v6 17/25] spl: Convert mmc " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 18/25] spl: Convert nand " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 19/25] spl: Convert net " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 20/25] spl: Convert nor " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:25 ` [PATCH v6 21/25] spl: Convert NVMe " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 22/25] spl: Convert semihosting " Sean Anderson
2023-11-06  2:26 ` [PATCH v6 23/25] spl: Convert spi " Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 24/25] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  2:26 ` [PATCH v6 25/25] spl: fat: Add option to disable DMA alignment Sean Anderson
2023-11-08  4:24   ` Simon Glass
2023-11-06  7:49 ` [PATCH v6 00/25] spl: Use common function for loading/parsing images Pali Rohár
2023-11-06  9:18   ` Heinrich Schuchardt
2023-11-06 10:12   ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231106022603.3405551-8-seanga2@gmail.com \
    --to=seanga2@gmail.com \
    --cc=festevam@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=xdrudis@tinet.cat \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox