* [PATCH] arm: mach-k3: Let the compiler size the mem_map lists
@ 2023-11-06 16:52 Andrew Davis
2023-11-22 20:48 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Davis @ 2023-11-06 16:52 UTC (permalink / raw)
To: Neha Malcom Francis, Simon Glass, Tom Rini, Vignesh Raghavendra,
Nishanth Menon
Cc: u-boot, Andrew Davis
NR_MMU_REGIONS is a copy/paste from another platform that extends
this list later. We do not do that, so let the list be the size
of the initializer list.
Signed-off-by: Andrew Davis <afd@ti.com>
---
arch/arm/mach-k3/arm64-mmu.c | 34 ++++++----------------------------
1 file changed, 6 insertions(+), 28 deletions(-)
diff --git a/arch/arm/mach-k3/arm64-mmu.c b/arch/arm/mach-k3/arm64-mmu.c
index f8087d2421e..471295fa7eb 100644
--- a/arch/arm/mach-k3/arm64-mmu.c
+++ b/arch/arm/mach-k3/arm64-mmu.c
@@ -14,11 +14,7 @@
#include <asm/armv8/mmu.h>
#ifdef CONFIG_SOC_K3_AM654
-/* NR_DRAM_BANKS + 32bit IO + 64bit IO + terminator */
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 5)
-
-/* ToDo: Add 64bit IO */
-struct mm_region am654_mem_map[NR_MMU_REGIONS] = {
+struct mm_region am654_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
@@ -69,11 +65,7 @@ struct mm_region *mem_map = am654_mem_map;
#ifdef CONFIG_SOC_K3_J721E
#ifdef CONFIG_TARGET_J721E_A72_EVM
-/* NR_DRAM_BANKS + 32bit IO + 64bit IO + terminator */
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 6)
-
-/* ToDo: Add 64bit IO */
-struct mm_region j721e_mem_map[NR_MMU_REGIONS] = {
+struct mm_region j721e_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
@@ -128,10 +120,7 @@ struct mm_region *mem_map = j721e_mem_map;
#endif /* CONFIG_TARGET_J721E_A72_EVM */
#ifdef CONFIG_TARGET_J7200_A72_EVM
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 5)
-
-/* ToDo: Add 64bit IO */
-struct mm_region j7200_mem_map[NR_MMU_REGIONS] = {
+struct mm_region j7200_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
@@ -182,10 +171,7 @@ struct mm_region *mem_map = j7200_mem_map;
#endif /* CONFIG_SOC_K3_J721E */
#ifdef CONFIG_SOC_K3_J721S2
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 3)
-
-/* ToDo: Add 64bit IO */
-struct mm_region j721s2_mem_map[NR_MMU_REGIONS] = {
+struct mm_region j721s2_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
@@ -224,11 +210,7 @@ struct mm_region *mem_map = j721s2_mem_map;
#if defined(CONFIG_SOC_K3_AM625) || defined(CONFIG_SOC_K3_AM62A7)
-/* NR_DRAM_BANKS + 32bit IO + 64bit IO + terminator */
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 4)
-
-/* ToDo: Add 64bit IO */
-struct mm_region am62_mem_map[NR_MMU_REGIONS] = {
+struct mm_region am62_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
@@ -273,11 +255,7 @@ struct mm_region *mem_map = am62_mem_map;
#ifdef CONFIG_SOC_K3_AM642
-/* NR_DRAM_BANKS + 32bit IO + 64bit IO + terminator */
-#define NR_MMU_REGIONS (CONFIG_NR_DRAM_BANKS + 4)
-
-/* ToDo: Add 64bit IO */
-struct mm_region am64_mem_map[NR_MMU_REGIONS] = {
+struct mm_region am64_mem_map[] = {
{
.virt = 0x0UL,
.phys = 0x0UL,
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mach-k3: Let the compiler size the mem_map lists
2023-11-06 16:52 [PATCH] arm: mach-k3: Let the compiler size the mem_map lists Andrew Davis
@ 2023-11-22 20:48 ` Tom Rini
2023-11-22 21:02 ` Andrew Davis
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2023-11-22 20:48 UTC (permalink / raw)
To: Andrew Davis
Cc: Neha Malcom Francis, Simon Glass, Vignesh Raghavendra,
Nishanth Menon, u-boot
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Mon, Nov 06, 2023 at 10:52:05AM -0600, Andrew Davis wrote:
> NR_MMU_REGIONS is a copy/paste from another platform that extends
> this list later. We do not do that, so let the list be the size
> of the initializer list.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> arch/arm/mach-k3/arm64-mmu.c | 34 ++++++----------------------------
> 1 file changed, 6 insertions(+), 28 deletions(-)
Please redo this on top of current next as the other series that have
gone in make this no longer apply, thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: mach-k3: Let the compiler size the mem_map lists
2023-11-22 20:48 ` Tom Rini
@ 2023-11-22 21:02 ` Andrew Davis
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Davis @ 2023-11-22 21:02 UTC (permalink / raw)
To: Tom Rini
Cc: Neha Malcom Francis, Simon Glass, Vignesh Raghavendra,
Nishanth Menon, u-boot
On 11/22/23 2:48 PM, Tom Rini wrote:
> On Mon, Nov 06, 2023 at 10:52:05AM -0600, Andrew Davis wrote:
>
>> NR_MMU_REGIONS is a copy/paste from another platform that extends
>> this list later. We do not do that, so let the list be the size
>> of the initializer list.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> arch/arm/mach-k3/arm64-mmu.c | 34 ++++++----------------------------
>> 1 file changed, 6 insertions(+), 28 deletions(-)
>
> Please redo this on top of current next as the other series that have
> gone in make this no longer apply, thanks.
>
Sure, sending v2 now.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-22 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-06 16:52 [PATCH] arm: mach-k3: Let the compiler size the mem_map lists Andrew Davis
2023-11-22 20:48 ` Tom Rini
2023-11-22 21:02 ` Andrew Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox