From: Tom Rini <trini@konsulko.com>
To: Bryan Brattlof <bb@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Andrew Davis <afd@ti.com>,
UBoot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH 2/3] configs: am62ax: setup the 32k RTC crystal
Date: Tue, 7 Nov 2023 18:32:31 -0500 [thread overview]
Message-ID: <20231107233231.GY6601@bill-the-cat> (raw)
In-Reply-To: <20231107232139.2839534-7-bb@ti.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Tue, Nov 07, 2023 at 05:21:42PM -0600, Bryan Brattlof wrote:
> The am62ax utilizes the same 32k crystal for a more accurate RTC clock
> source. Enable the configuration to set this up for Linux.
>
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
> board/ti/am62ax/evm.c | 5 +++++
> configs/am62ax_evm_a53_defconfig | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/board/ti/am62ax/evm.c b/board/ti/am62ax/evm.c
> index f2dd3b4192ee0..6e031784766c4 100644
> --- a/board/ti/am62ax/evm.c
> +++ b/board/ti/am62ax/evm.c
> @@ -14,8 +14,13 @@
> #include <fdt_support.h>
> #include <spl.h>
>
> +#include "../common/rtc.c"
Oh goodness, no, we don't include a C file without very good reason.
Build that object based on whatever the right symbol name is (based on
my feedback in 1/3) and find some appropriate header for the function
prototype to be in as well. And this applies to 3/3 as well.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-11-07 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 23:21 [PATCH 0/3] board: ti: common: setup mux and debounce for 32k RTC crystal Bryan Brattlof
2023-11-07 23:21 ` [PATCH 1/3] board: ti: common: add rtc setup to common folder Bryan Brattlof
2023-11-07 23:30 ` Tom Rini
2023-11-08 15:46 ` Bryan Brattlof
2023-11-08 16:49 ` Tom Rini
2023-11-08 7:26 ` Vignesh Raghavendra
2023-11-08 15:38 ` Bryan Brattlof
2023-11-07 23:21 ` [PATCH 2/3] configs: am62ax: setup the 32k RTC crystal Bryan Brattlof
2023-11-07 23:32 ` Tom Rini [this message]
2023-11-07 23:21 ` [PATCH 3/3] configs: am62x: move 32K RTC crystal to common Bryan Brattlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107233231.GY6601@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=christian.gmeiner@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox