Re: [PATCH 2/3] configs: am62ax: setup the 32k RTC crystal

Tom Rini
2023-11-07T23:32:39Z

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On Tue, Nov 07, 2023 at 05:21:42PM -0600, Bryan Brattlof wrote:

> The am62ax utilizes the same 32k crystal for a more accurate RTC clock
> source. Enable the configuration to set this up for Linux.
>
> Signed-off-by: Bryan Brattlof <bb@ti.com>
> ---
> board/ti/am62ax/evm.c | 5 +++++
> configs/am62ax_evm_a53_defconfig | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/board/ti/am62ax/evm.c b/board/ti/am62ax/evm.c
> index f2dd3b4192ee0..6e031784766c4 100644
> --- a/board/ti/am62ax/evm.c
> +++ b/board/ti/am62ax/evm.c
> @@ -14,8 +14,13 @@
> #include <fdt_support.h>
> #include <spl.h>
>
> +#include "../common/rtc.c"

Oh goodness, no, we don't include a C file without very good reason.
Build that object based on whatever the right symbol name is (based on
my feedback in 1/3) and find some appropriate header for the function
prototype to be in as well. And this applies to 3/3 as well.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]