Re: [PATCH 1/3] board: ti: common: add rtc setup to common folder

Bryan Brattlof
2023-11-08T15:38:54Z

On November 8, 2023 thus sayeth Vignesh Raghavendra:
> On 08/11/23 04:51, Bryan Brattlof wrote:
> > All of the starter kit boards for the am62xxx extended family utilize
> > the same 32k crystal oscillator for a more accurate clock for the RTC
> > instance. Add the setup the clock mux and debounce configuration to the
> > common board directory so the entire am62xxx extended family can utilize
> > it.
> >
> > Signed-off-by: Bryan Brattlof <bb@ti.com>
> > ---

...

> > + /* Setup debounce conf registers - arbitrary values.
> > + * Times are approx
> > + */
> > + /* 1.9ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG1, 0x1);
> > + /* 5ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG2, 0x5);
> > + /* 20ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG3, 0x14);
> > + /* 46ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG4, 0x18);
> > + /* 100ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG5, 0x1c);
> > + /* 156ms debounce @ 32k */
> > + writel(WKUP_CTRLMMR_DBOUNCE_CFG6, 0x1f);
> > +}
>
>
> Pad Debounce settings has nothing to do with RTC. This doesn't belong to
> board_rtc_init()
>

Oops.. I have no idea what I was thinking yesterday. This was a really
half-baked plan all the way through :)

I'll get this properly sorted out for v2

Thanks for reviewing though
~Bryan