From: Tom Rini <trini@konsulko.com>
To: Love Kumar <love.kumar@amd.com>
Cc: u-boot@lists.denx.de, michal.simek@amd.com, git@xilinx.com,
rfried.dev@gmail.com, v.v.mitrofanov@yadro.com,
seanedmond@microsoft.com, emohandesi@linux.microsoft.com
Subject: Re: [UBOOT PATCH v2] test/py: net: Add dhcp abort test
Date: Wed, 8 Nov 2023 09:41:53 -0500 [thread overview]
Message-ID: <20231108144153.GA1069311@bill-the-cat> (raw)
In-Reply-To: <214217fdd0d69a107482c5c6f6dce96894aa5dc1.1698757115.git.love.kumar@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
On Tue, Oct 31, 2023 at 06:29:20PM +0530, Love Kumar wrote:
> Abort the dhcp request in the middle by pressing ctrl + c on u-boot
> prompt and validate the abort status.
>
> Signed-off-by: Love Kumar <love.kumar@amd.com>
> ---
> Changes in v2:
> - Mark CMD_MII command dependency
This doesn't work for me on a raspberry pi 3 in 32bit mode (and I
suspect fails on the rest of the Pi families and builds as well):
test/py/tests/test_net.py ..F
========================================== FAILURES ===========================================
_____________________________________ test_net_dhcp_abort _____________________________________
test/py/tests/test_net.py:139: in test_net_dhcp_abort
eth_num = re.search(r"Current device: '(.+?)'", output).groups()[0]
E AttributeError: 'NoneType' object has no attribute 'groups'
------------------------------------ Captured stdout call -------------------------------------
U-Boot> setenv autoload no
U-Boot> U-Boot> mii device
MII devices:
U-Boot>
=================================== short test summary info ===================================
FAILED test/py/tests/test_net.py::test_net_dhcp_abort - AttributeError: 'NoneType' object ha...
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
========================= 1 failed, 101 passed, 86 skipped in 39.89s ==========================
Perhaps the method you use to interrupt the dhcp attempt needs
re-thinking? I don't know if we can reliably inject control-c instead
quick enough to the console.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-11-08 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:59 [UBOOT PATCH v2] test/py: net: Add dhcp abort test Love Kumar
2023-11-08 14:41 ` Tom Rini [this message]
2023-11-09 11:42 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108144153.GA1069311@bill-the-cat \
--to=trini@konsulko.com \
--cc=emohandesi@linux.microsoft.com \
--cc=git@xilinx.com \
--cc=love.kumar@amd.com \
--cc=michal.simek@amd.com \
--cc=rfried.dev@gmail.com \
--cc=seanedmond@microsoft.com \
--cc=u-boot@lists.denx.de \
--cc=v.v.mitrofanov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox