Re: [PATCH v11 09/24] cli: Add menu for hush parser

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

On Tue, Nov 07, 2023 at 11:41:06PM +0200, Francis Laniel wrote:

> For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the
> default.
> The goal is to prepare the field to add a new hush parser which guarantees
> actual behavior is still correct.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
> ---
>  cmd/Kconfig     | 13 +++++++++++++
>  common/Makefile |  2 +-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index fd16c3a48e..f3a00ee59b 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -23,6 +23,19 @@ config HUSH_PARSER
>  	  If disabled, you get the old, much simpler behaviour with a somewhat
>  	  smaller memory footprint.
>  
> +menu "Hush flavor to use"
> +	depends on HUSH_PARSER
> +
> +	config HUSH_OLD_PARSER
> +		bool "Use hush old parser"
> +		default y
> +		help
> +		  This option enables the old flavor of hush based on hush Busybox from
> +		  2005.
> +
> +		  It is actually the default U-Boot shell when decided to use hush as shell.
> +endmenu

The indentation is very wrong here, please fix it.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]