From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Cc: Johan Jonker <jbx6244@gmail.com>
Subject: Re: [PATCH] scsi: Have scsi_init_dev_desc_priv() use memset
Date: Fri, 10 Nov 2023 11:21:24 -0500 [thread overview]
Message-ID: <20231110162124.GV6601@bill-the-cat> (raw)
In-Reply-To: <20231108192811.1844338-1-trini@konsulko.com>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Wed, Nov 08, 2023 at 02:28:11PM -0500, Tom Rini wrote:
> When we do not have CONFIG_BOUNCE_BUFFER enabled, inside of
> scsi_init_dev_desc_priv we never set the 'bb' field to false, we only
> initialize it to true when CONFIG_BOUNCE_BUFFER is set. Given that we
> have a number of other fields here we had been explicitly setting to
> zero, change to first calling memset to clear the struct and then
> initialize only the fields that need non-zero default values.
>
> Addresses-Coverity-ID: 467407 ("Uninitialized variables (UNINIT)")
> Fixes: 81bd22e935dc ("rockchip: block: blk-uclass: add bounce buffer flag to blk_desc")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-11-10 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 19:28 [PATCH] scsi: Have scsi_init_dev_desc_priv() use memset Tom Rini
2023-11-09 1:15 ` Simon Glass
2023-11-10 16:21 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110162124.GV6601@bill-the-cat \
--to=trini@konsulko.com \
--cc=jbx6244@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox