* [PATCH] arm: dts: rockpro64: Add RockPro64 smbios
@ 2023-11-10 23:58 Shantur Rathore
2023-11-11 0:26 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Shantur Rathore @ 2023-11-10 23:58 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, Shantur Rathore
---
arch/arm/dts/rk3399-rockpro64.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399-rockpro64.dtsi
index 6bff8db7d3..cf850a69e6 100644
--- a/arch/arm/dts/rk3399-rockpro64.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64.dtsi
@@ -20,6 +20,26 @@
stdout-path = "serial2:1500000n8";
};
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+ smbios {
+ system {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ baseboard {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ chassis {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+ };
+ };
+
clkin_gmac: external-gmac-clock {
compatible = "fixed-clock";
clock-frequency = <125000000>;
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-10 23:58 [PATCH] arm: dts: rockpro64: Add RockPro64 smbios Shantur Rathore
@ 2023-11-11 0:26 ` Tom Rini
2023-11-11 11:43 ` Shantur Rathore
2023-11-13 10:01 ` [PATCH v3] " Shantur Rathore
2 siblings, 0 replies; 14+ messages in thread
From: Tom Rini @ 2023-11-11 0:26 UTC (permalink / raw)
To: Shantur Rathore; +Cc: u-boot, sjg, philipp.tomsich, kever.yang
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Fri, Nov 10, 2023 at 11:58:06PM +0000, Shantur Rathore wrote:
> ---
> arch/arm/dts/rk3399-rockpro64.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi b/arch/arm/dts/rk3399-rockpro64.dtsi
> index 6bff8db7d3..cf850a69e6 100644
> --- a/arch/arm/dts/rk3399-rockpro64.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64.dtsi
> @@ -20,6 +20,26 @@
> stdout-path = "serial2:1500000n8";
> };
>
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
This needs to be in a -u-boot.dtsi file.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-10 23:58 [PATCH] arm: dts: rockpro64: Add RockPro64 smbios Shantur Rathore
2023-11-11 0:26 ` Tom Rini
@ 2023-11-11 11:43 ` Shantur Rathore
2023-11-13 10:01 ` [PATCH v3] " Shantur Rathore
2 siblings, 0 replies; 14+ messages in thread
From: Shantur Rathore @ 2023-11-11 11:43 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, trini, Shantur Rathore
Signed-off-by: Shantur Rathore <i@shantur.com>
---
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index 732727d9b0..a4453e76f6 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -9,6 +9,28 @@
chosen {
u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
};
+
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+ smbios {
+ system {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ baseboard {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ chassis {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+ };
+ };
+
+
};
&sdhci {
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v3] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-10 23:58 [PATCH] arm: dts: rockpro64: Add RockPro64 smbios Shantur Rathore
2023-11-11 0:26 ` Tom Rini
2023-11-11 11:43 ` Shantur Rathore
@ 2023-11-13 10:01 ` Shantur Rathore
2023-11-13 10:16 ` Dragan Simic
2 siblings, 1 reply; 14+ messages in thread
From: Shantur Rathore @ 2023-11-13 10:01 UTC (permalink / raw)
To: u-boot
Cc: sjg, philipp.tomsich, kever.yang, trini, agan, akash,
Shantur Rathore
Add smbios information for Pine64 RockPro64 board and enable in
config
Signed-off-by: Shantur Rathore <i@shantur.com>
---
Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
configs/rockpro64-rk3399_defconfig | 2 ++
2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index 732727d9b0..a4453e76f6 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -9,6 +9,28 @@
chosen {
u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
};
+
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+ smbios {
+ system {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ baseboard {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+
+ chassis {
+ manufacturer = "PINE64";
+ product = "RockPro64";
+ };
+ };
+ };
+
+
};
&sdhci {
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
index 4cd6b76665..affb6137e0 100644
--- a/configs/rockpro64-rk3399_defconfig
+++ b/configs/rockpro64-rk3399_defconfig
@@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYS_NS16550_MEM32=y
CONFIG_ROCKCHIP_SPI=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_SYSRESET=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v3] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-13 10:01 ` [PATCH v3] " Shantur Rathore
@ 2023-11-13 10:16 ` Dragan Simic
2023-11-13 11:23 ` [PATCH v4] " Shantur Rathore
0 siblings, 1 reply; 14+ messages in thread
From: Dragan Simic @ 2023-11-13 10:16 UTC (permalink / raw)
To: Shantur Rathore; +Cc: u-boot, sjg, philipp.tomsich, kever.yang, trini, agan
On 2023-11-13 11:01, Shantur Rathore wrote:
> Add smbios information for Pine64 RockPro64 board and enable in
> config
>
> Signed-off-by: Shantur Rathore <i@shantur.com>
> ---
> Changes v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
>
> arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/rockpro64-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 732727d9b0..a4453e76f6 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -9,6 +9,28 @@
> chosen {
> u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> };
> +
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> + smbios {
> + system {
> + manufacturer = "PINE64";
> + product = "RockPro64";
> + };
> +
> + baseboard {
> + manufacturer = "PINE64";
> + product = "RockPro64";
> + };
> +
> + chassis {
> + manufacturer = "PINE64";
> + product = "RockPro64";
> + };
> + };
> + };
> +
> +
> };
Perhaps it would be better to use "Pine64" instead of "PINE64", because
"Pine64" is already used in multiple places. Also, it might be better to
use "ROCKPro64" instead of "RockPro64", because that's actually the
official name of the board, but I'm also perfectly fine with
"RockPro64".
> &sdhci {
> diff --git a/configs/rockpro64-rk3399_defconfig
> b/configs/rockpro64-rk3399_defconfig
> index 4cd6b76665..affb6137e0 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_ROCKCHIP_SPI=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> CONFIG_USB_XHCI_HCD=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-13 10:16 ` Dragan Simic
@ 2023-11-13 11:23 ` Shantur Rathore
2023-12-11 20:42 ` Shantur Rathore
2023-12-12 0:18 ` Kever Yang
0 siblings, 2 replies; 14+ messages in thread
From: Shantur Rathore @ 2023-11-13 11:23 UTC (permalink / raw)
To: u-boot
Cc: sjg, philipp.tomsich, kever.yang, trini, jagan, akash,
Shantur Rathore
Add smbios information for Pine64 RockPro64 board and enable in
config
Signed-off-by: Shantur Rathore <i@shantur.com>
---
Changes
v4: Change PINE64 to Pine64
v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
configs/rockpro64-rk3399_defconfig | 2 ++
2 files changed, 24 insertions(+)
diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index 732727d9b0..089732524a 100644
--- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -9,6 +9,28 @@
chosen {
u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
};
+
+ smbios {
+ compatible = "u-boot,sysinfo-smbios";
+ smbios {
+ system {
+ manufacturer = "Pine64";
+ product = "RockPro64";
+ };
+
+ baseboard {
+ manufacturer = "Pine64";
+ product = "RockPro64";
+ };
+
+ chassis {
+ manufacturer = "Pine64";
+ product = "RockPro64";
+ };
+ };
+ };
+
+
};
&sdhci {
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
index 4cd6b76665..affb6137e0 100644
--- a/configs/rockpro64-rk3399_defconfig
+++ b/configs/rockpro64-rk3399_defconfig
@@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYS_NS16550_MEM32=y
CONFIG_ROCKCHIP_SPI=y
+CONFIG_SYSINFO=y
+CONFIG_SYSINFO_SMBIOS=y
CONFIG_SYSRESET=y
CONFIG_USB=y
CONFIG_USB_XHCI_HCD=y
--
2.40.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-13 11:23 ` [PATCH v4] " Shantur Rathore
@ 2023-12-11 20:42 ` Shantur Rathore
2023-12-11 20:53 ` Tom Rini
2023-12-12 0:18 ` Kever Yang
1 sibling, 1 reply; 14+ messages in thread
From: Shantur Rathore @ 2023-12-11 20:42 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, trini, jagan
Hi,
On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
>
> Add smbios information for Pine64 RockPro64 board and enable in
> config
>
> Signed-off-by: Shantur Rathore <i@shantur.com>
> ---
> Changes
> v4: Change PINE64 to Pine64
> v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
>
> arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/rockpro64-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 732727d9b0..089732524a 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -9,6 +9,28 @@
> chosen {
> u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> };
> +
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> + smbios {
> + system {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> +
> + baseboard {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> +
> + chassis {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> + };
> + };
> +
> +
> };
>
> &sdhci {
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 4cd6b76665..affb6137e0 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_ROCKCHIP_SPI=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> CONFIG_USB_XHCI_HCD=y
> --
> 2.40.1
>
Can this please be merged if no changes are required?
[0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@shantur.com/
Kind regards,
Shantur
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-11 20:42 ` Shantur Rathore
@ 2023-12-11 20:53 ` Tom Rini
2023-12-13 19:50 ` Simon Glass
0 siblings, 1 reply; 14+ messages in thread
From: Tom Rini @ 2023-12-11 20:53 UTC (permalink / raw)
To: Shantur Rathore; +Cc: u-boot, sjg, philipp.tomsich, kever.yang, jagan
[-- Attachment #1: Type: text/plain, Size: 2577 bytes --]
On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> Hi,
>
> On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> >
> > Add smbios information for Pine64 RockPro64 board and enable in
> > config
> >
> > Signed-off-by: Shantur Rathore <i@shantur.com>
> > ---
> > Changes
> > v4: Change PINE64 to Pine64
> > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> >
> > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > configs/rockpro64-rk3399_defconfig | 2 ++
> > 2 files changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > index 732727d9b0..089732524a 100644
> > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > @@ -9,6 +9,28 @@
> > chosen {
> > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > };
> > +
> > + smbios {
> > + compatible = "u-boot,sysinfo-smbios";
> > + smbios {
> > + system {
> > + manufacturer = "Pine64";
> > + product = "RockPro64";
> > + };
> > +
> > + baseboard {
> > + manufacturer = "Pine64";
> > + product = "RockPro64";
> > + };
> > +
> > + chassis {
> > + manufacturer = "Pine64";
> > + product = "RockPro64";
> > + };
> > + };
> > + };
> > +
> > +
> > };
> >
> > &sdhci {
> > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> > index 4cd6b76665..affb6137e0 100644
> > --- a/configs/rockpro64-rk3399_defconfig
> > +++ b/configs/rockpro64-rk3399_defconfig
> > @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> > CONFIG_DEBUG_UART_SHIFT=2
> > CONFIG_SYS_NS16550_MEM32=y
> > CONFIG_ROCKCHIP_SPI=y
> > +CONFIG_SYSINFO=y
> > +CONFIG_SYSINFO_SMBIOS=y
> > CONFIG_SYSRESET=y
> > CONFIG_USB=y
> > CONFIG_USB_XHCI_HCD=y
> > --
> > 2.40.1
> >
>
> Can this please be merged if no changes are required?
>
> [0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@shantur.com/
Yes, we should just defer this and pickup the SMBIOS series that Ilias
has posted.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-11-13 11:23 ` [PATCH v4] " Shantur Rathore
2023-12-11 20:42 ` Shantur Rathore
@ 2023-12-12 0:18 ` Kever Yang
1 sibling, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-12-12 0:18 UTC (permalink / raw)
To: Shantur Rathore, u-boot; +Cc: sjg, philipp.tomsich, trini, jagan, akash
On 2023/11/13 19:23, Shantur Rathore wrote:
> Add smbios information for Pine64 RockPro64 board and enable in
> config
>
> Signed-off-by: Shantur Rathore <i@shantur.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> Changes
> v4: Change PINE64 to Pine64
> v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
>
> arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/rockpro64-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 732727d9b0..089732524a 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -9,6 +9,28 @@
> chosen {
> u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> };
> +
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> + smbios {
> + system {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> +
> + baseboard {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> +
> + chassis {
> + manufacturer = "Pine64";
> + product = "RockPro64";
> + };
> + };
> + };
> +
> +
> };
>
> &sdhci {
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 4cd6b76665..affb6137e0 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_ROCKCHIP_SPI=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
> CONFIG_SYSRESET=y
> CONFIG_USB=y
> CONFIG_USB_XHCI_HCD=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-11 20:53 ` Tom Rini
@ 2023-12-13 19:50 ` Simon Glass
2023-12-13 20:29 ` Tom Rini
0 siblings, 1 reply; 14+ messages in thread
From: Simon Glass @ 2023-12-13 19:50 UTC (permalink / raw)
To: Tom Rini; +Cc: Shantur Rathore, u-boot, philipp.tomsich, kever.yang, jagan
Hi Tom,
On Mon, 11 Dec 2023 at 13:53, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > Hi,
> >
> > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> > >
> > > Add smbios information for Pine64 RockPro64 board and enable in
> > > config
> > >
> > > Signed-off-by: Shantur Rathore <i@shantur.com>
> > > ---
> > > Changes
> > > v4: Change PINE64 to Pine64
> > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > >
> > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > 2 files changed, 24 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > index 732727d9b0..089732524a 100644
> > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > @@ -9,6 +9,28 @@
> > > chosen {
> > > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > > };
> > > +
> > > + smbios {
> > > + compatible = "u-boot,sysinfo-smbios";
> > > + smbios {
> > > + system {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > +
> > > + baseboard {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > +
> > > + chassis {
> > > + manufacturer = "Pine64";
> > > + product = "RockPro64";
> > > + };
> > > + };
> > > + };
> > > +
> > > +
> > > };
> > >
> > > &sdhci {
> > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> > > index 4cd6b76665..affb6137e0 100644
> > > --- a/configs/rockpro64-rk3399_defconfig
> > > +++ b/configs/rockpro64-rk3399_defconfig
> > > @@ -90,6 +90,8 @@ CONFIG_BAUDRATE=1500000
> > > CONFIG_DEBUG_UART_SHIFT=2
> > > CONFIG_SYS_NS16550_MEM32=y
> > > CONFIG_ROCKCHIP_SPI=y
> > > +CONFIG_SYSINFO=y
> > > +CONFIG_SYSINFO_SMBIOS=y
> > > CONFIG_SYSRESET=y
> > > CONFIG_USB=y
> > > CONFIG_USB_XHCI_HCD=y
> > > --
> > > 2.40.1
> > >
> >
> > Can this please be merged if no changes are required?
> >
> > [0] - https://patchwork.ozlabs.org/project/uboot/patch/20231113112309.730323-1-i@shantur.com/
>
> Yes, we should just defer this and pickup the SMBIOS series that Ilias
> has posted.
I don't think it is a suitable substitute, it is just a fallback.
So I believe this patch should be applied.
Reviewed-by: Simon Glass <sjg@chromium.org>
Regards,
Simon
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-13 19:50 ` Simon Glass
@ 2023-12-13 20:29 ` Tom Rini
2023-12-13 20:41 ` Simon Glass
0 siblings, 1 reply; 14+ messages in thread
From: Tom Rini @ 2023-12-13 20:29 UTC (permalink / raw)
To: Simon Glass; +Cc: Shantur Rathore, u-boot, philipp.tomsich, kever.yang, jagan
[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]
On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Mon, 11 Dec 2023 at 13:53, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > > Hi,
> > >
> > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> > > >
> > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > config
> > > >
> > > > Signed-off-by: Shantur Rathore <i@shantur.com>
> > > > ---
> > > > Changes
> > > > v4: Change PINE64 to Pine64
> > > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > >
> > > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > > 2 files changed, 24 insertions(+)
> > > >
> > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > index 732727d9b0..089732524a 100644
> > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > @@ -9,6 +9,28 @@
> > > > chosen {
> > > > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > > > };
> > > > +
> > > > + smbios {
> > > > + compatible = "u-boot,sysinfo-smbios";
> > > > + smbios {
> > > > + system {
> > > > + manufacturer = "Pine64";
> > > > + product = "RockPro64";
> > > > + };
[snip]
> > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > has posted.
>
> I don't think it is a suitable substitute, it is just a fallback.
>
> So I believe this patch should be applied.
Please note that this patch is adding _less_ details than the top-level
model field contains today for the platform. The only difference is
"Pine64" vs "pine64".
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-13 20:29 ` Tom Rini
@ 2023-12-13 20:41 ` Simon Glass
2023-12-14 14:14 ` Shantur Rathore
0 siblings, 1 reply; 14+ messages in thread
From: Simon Glass @ 2023-12-13 20:41 UTC (permalink / raw)
To: Tom Rini; +Cc: Shantur Rathore, u-boot, philipp.tomsich, kever.yang, jagan
Hi Tom,
On Wed, 13 Dec 2023 at 13:29, Tom Rini <trini@konsulko.com> wrote:
>
> On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Mon, 11 Dec 2023 at 13:53, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > > > Hi,
> > > >
> > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> > > > >
> > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > config
> > > > >
> > > > > Signed-off-by: Shantur Rathore <i@shantur.com>
> > > > > ---
> > > > > Changes
> > > > > v4: Change PINE64 to Pine64
> > > > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > >
> > > > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > > > 2 files changed, 24 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > index 732727d9b0..089732524a 100644
> > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > @@ -9,6 +9,28 @@
> > > > > chosen {
> > > > > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > > > > };
> > > > > +
> > > > > + smbios {
> > > > > + compatible = "u-boot,sysinfo-smbios";
> > > > > + smbios {
> > > > > + system {
> > > > > + manufacturer = "Pine64";
> > > > > + product = "RockPro64";
> > > > > + };
> [snip]
> > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > has posted.
> >
> > I don't think it is a suitable substitute, it is just a fallback.
> >
> > So I believe this patch should be applied.
>
> Please note that this patch is adding _less_ details than the top-level
> model field contains today for the platform. The only difference is
> "Pine64" vs "pine64".
The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
- the first part of that is the manufacturer, not the product
- the second part is what we have in this patch
- the third part is the version
SMBIOS tries to split things up into separate fields.
So, perhaps a new version of this patch could add:
system {
version = "2.1";
};
Regards,
Simon
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-13 20:41 ` Simon Glass
@ 2023-12-14 14:14 ` Shantur Rathore
2023-12-16 18:46 ` Simon Glass
0 siblings, 1 reply; 14+ messages in thread
From: Shantur Rathore @ 2023-12-14 14:14 UTC (permalink / raw)
To: Simon Glass; +Cc: Tom Rini, u-boot, philipp.tomsich, kever.yang, jagan
Hi,
On Wed, Dec 13, 2023 at 8:41 PM Simon Glass <sjg@chromium.org> wrote:
>
> Hi Tom,
>
> On Wed, 13 Dec 2023 at 13:29, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Mon, 11 Dec 2023 at 13:53, Tom Rini <trini@konsulko.com> wrote:
> > > >
> > > > On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > > > > Hi,
> > > > >
> > > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> > > > > >
> > > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > > config
> > > > > >
> > > > > > Signed-off-by: Shantur Rathore <i@shantur.com>
> > > > > > ---
> > > > > > Changes
> > > > > > v4: Change PINE64 to Pine64
> > > > > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > > >
> > > > > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > > > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > > > > 2 files changed, 24 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > index 732727d9b0..089732524a 100644
> > > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > @@ -9,6 +9,28 @@
> > > > > > chosen {
> > > > > > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > > > > > };
> > > > > > +
> > > > > > + smbios {
> > > > > > + compatible = "u-boot,sysinfo-smbios";
> > > > > > + smbios {
> > > > > > + system {
> > > > > > + manufacturer = "Pine64";
> > > > > > + product = "RockPro64";
> > > > > > + };
> > [snip]
> > > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > > has posted.
> > >
> > > I don't think it is a suitable substitute, it is just a fallback.
> > >
> > > So I believe this patch should be applied.
> >
> > Please note that this patch is adding _less_ details than the top-level
> > model field contains today for the platform. The only difference is
> > "Pine64" vs "pine64".
>
> The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
>
> - the first part of that is the manufacturer, not the product
> - the second part is what we have in this patch
> - the third part is the version
>
> SMBIOS tries to split things up into separate fields.
>
> So, perhaps a new version of this patch could add:
>
> system {
> version = "2.1";
> };
>
I can add the above or any more details needed to a new patch
Will that be enough to make it merge-able
Kind regards,
Shantur
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios
2023-12-14 14:14 ` Shantur Rathore
@ 2023-12-16 18:46 ` Simon Glass
0 siblings, 0 replies; 14+ messages in thread
From: Simon Glass @ 2023-12-16 18:46 UTC (permalink / raw)
To: Shantur Rathore; +Cc: Tom Rini, u-boot, philipp.tomsich, kever.yang, jagan
Hi Shantur,
On Thu, 14 Dec 2023 at 07:14, Shantur Rathore <i@shantur.com> wrote:
>
> Hi,
>
> On Wed, Dec 13, 2023 at 8:41 PM Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Tom,
> >
> > On Wed, 13 Dec 2023 at 13:29, Tom Rini <trini@konsulko.com> wrote:
> > >
> > > On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On Mon, 11 Dec 2023 at 13:53, Tom Rini <trini@konsulko.com> wrote:
> > > > >
> > > > > On Mon, Dec 11, 2023 at 08:42:19PM +0000, Shantur Rathore wrote:
> > > > > > Hi,
> > > > > >
> > > > > > On Mon, Nov 13, 2023 at 11:24 AM Shantur Rathore <i@shantur.com> wrote:
> > > > > > >
> > > > > > > Add smbios information for Pine64 RockPro64 board and enable in
> > > > > > > config
> > > > > > >
> > > > > > > Signed-off-by: Shantur Rathore <i@shantur.com>
> > > > > > > ---
> > > > > > > Changes
> > > > > > > v4: Change PINE64 to Pine64
> > > > > > > v3: Enable SYSINFO and SYSINFO_SMBIOS in defconfig
> > > > > > >
> > > > > > > arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 22 ++++++++++++++++++++++
> > > > > > > configs/rockpro64-rk3399_defconfig | 2 ++
> > > > > > > 2 files changed, 24 insertions(+)
> > > > > > >
> > > > > > > diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > index 732727d9b0..089732524a 100644
> > > > > > > --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> > > > > > > @@ -9,6 +9,28 @@
> > > > > > > chosen {
> > > > > > > u-boot,spl-boot-order = "same-as-spl", &spi_flash, &sdmmc, &sdhci;
> > > > > > > };
> > > > > > > +
> > > > > > > + smbios {
> > > > > > > + compatible = "u-boot,sysinfo-smbios";
> > > > > > > + smbios {
> > > > > > > + system {
> > > > > > > + manufacturer = "Pine64";
> > > > > > > + product = "RockPro64";
> > > > > > > + };
> > > [snip]
> > > > > Yes, we should just defer this and pickup the SMBIOS series that Ilias
> > > > > has posted.
> > > >
> > > > I don't think it is a suitable substitute, it is just a fallback.
> > > >
> > > > So I believe this patch should be applied.
> > >
> > > Please note that this patch is adding _less_ details than the top-level
> > > model field contains today for the platform. The only difference is
> > > "Pine64" vs "pine64".
> >
> > The top-level model is "Pine64 RockPro64 v2.1", I believe. But:
> >
> > - the first part of that is the manufacturer, not the product
> > - the second part is what we have in this patch
> > - the third part is the version
> >
> > SMBIOS tries to split things up into separate fields.
> >
> > So, perhaps a new version of this patch could add:
> >
> > system {
> > version = "2.1";
> > };
> >
>
> I can add the above or any more details needed to a new patch
> Will that be enough to make it merge-able
From my POV, yes. Having dug into this a bit, patches like this are
the only way we can get authoritative SMBIOS data. There are various
user-space workarounds, but these should not cause any problems.
Regards,
Simon
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-12-16 18:51 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 23:58 [PATCH] arm: dts: rockpro64: Add RockPro64 smbios Shantur Rathore
2023-11-11 0:26 ` Tom Rini
2023-11-11 11:43 ` Shantur Rathore
2023-11-13 10:01 ` [PATCH v3] " Shantur Rathore
2023-11-13 10:16 ` Dragan Simic
2023-11-13 11:23 ` [PATCH v4] " Shantur Rathore
2023-12-11 20:42 ` Shantur Rathore
2023-12-11 20:53 ` Tom Rini
2023-12-13 19:50 ` Simon Glass
2023-12-13 20:29 ` Tom Rini
2023-12-13 20:41 ` Simon Glass
2023-12-14 14:14 ` Shantur Rathore
2023-12-16 18:46 ` Simon Glass
2023-12-12 0:18 ` Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox