From: Mayuresh Chitale <mchitale@ventanamicro.com>
To: Michal Simek <michal.simek@amd.com>, Bo Gan <ganboing@gmail.com>,
Puhan Zhou <puh4n.zhou@gmail.com>,
Eugen Hristev <eugen.hristev@collabora.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jonas Karlman <jonas@kwiboo.se>,
Valentin Caron <valentin.caron@foss.st.com>,
Shengyu Qu <wiagn233@outlook.com>
Cc: Mayuresh Chitale <mchitale@ventanamicro.com>,
u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Tom Rini <trini@konsulko.com>
Subject: [PATCH v2] pci: xilinx: Enable MMIO region
Date: Sat, 11 Nov 2023 23:06:04 +0530 [thread overview]
Message-ID: <20231111173604.93103-3-mchitale@ventanamicro.com> (raw)
In-Reply-To: <20231111173604.93103-1-mchitale@ventanamicro.com>
The host bridge MMIO region is disabled by default due to which MMIO
accesses cause an exception. Fix it by setting the bridge enable bit.
This change is ported from the linux pcie-xilinx driver.
Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
---
Changes in v2:
====
Add Reviewed-by Tag.
drivers/pci/pcie_xilinx.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/pci/pcie_xilinx.c b/drivers/pci/pcie_xilinx.c
index c1f5bbbb1b..7052d6dac8 100644
--- a/drivers/pci/pcie_xilinx.c
+++ b/drivers/pci/pcie_xilinx.c
@@ -23,6 +23,8 @@ struct xilinx_pcie {
/* Register definitions */
#define XILINX_PCIE_REG_PSCR 0x144
#define XILINX_PCIE_REG_PSCR_LNKUP BIT(11)
+#define XILINX_PCIE_REG_RPSC 0x148
+#define XILINX_PCIE_REG_RPSC_BEN BIT(0)
/**
* pcie_xilinx_link_up() - Check whether the PCIe link is up
@@ -140,6 +142,7 @@ static int pcie_xilinx_of_to_plat(struct udevice *dev)
struct xilinx_pcie *pcie = dev_get_priv(dev);
fdt_addr_t addr;
fdt_size_t size;
+ u32 rpsc;
addr = dev_read_addr_size(dev, &size);
if (addr == FDT_ADDR_T_NONE)
@@ -147,6 +150,11 @@ static int pcie_xilinx_of_to_plat(struct udevice *dev)
pcie->cfg_base = devm_ioremap(dev, addr, size);
+ /* Enable the Bridge enable bit */
+ rpsc = __raw_readl(pcie->cfg_base + XILINX_PCIE_REG_RPSC);
+ rpsc |= XILINX_PCIE_REG_RPSC_BEN;
+ __raw_writel(rpsc, pcie->cfg_base + XILINX_PCIE_REG_RPSC);
+
return 0;
}
--
2.34.1
next prev parent reply other threads:[~2023-11-11 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 17:36 [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Mayuresh Chitale
2023-11-11 17:36 ` [PATCH v2] net: axi_emac: Use reg property for DMA registers Mayuresh Chitale
2023-11-13 9:10 ` Michal Simek
2023-11-16 13:22 ` mchitale
2023-11-11 17:36 ` Mayuresh Chitale [this message]
2023-11-13 8:10 ` [PATCH v2] drivers: pcie_xilinx: Fix "reg" not found error Michal Simek
2023-11-16 13:29 ` mchitale
2023-11-13 9:12 ` Michal Simek
2023-11-16 13:30 ` mchitale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231111173604.93103-3-mchitale@ventanamicro.com \
--to=mchitale@ventanamicro.com \
--cc=eugen.hristev@collabora.com \
--cc=ganboing@gmail.com \
--cc=jonas@kwiboo.se \
--cc=michal.simek@amd.com \
--cc=puh4n.zhou@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=valentin.caron@foss.st.com \
--cc=wiagn233@outlook.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox