From: Devarsh Thakkar <devarsht@ti.com>
To: <u-boot@lists.denx.de>, <sjg@chromium.org>, <agust@denx.de>,
<trini@konsulko.com>, <bmeng.cn@gmail.com>, <msuchanek@suse.de>,
<rasmus.villemoes@prevas.dk>, <yangshiji66@outlook.com>
Cc: <praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
<a-bhatia1@ti.com>, <j-luthra@ti.com>, <nsekhar@ti.com>,
<n-jain1@ti.com>, <devarsht@ti.com>
Subject: [PATCH v5 0/8] Move framebuffer reservation for SPL to RAM end
Date: Tue, 5 Dec 2023 21:25:15 +0530 [thread overview]
Message-ID: <20231205155523.721784-1-devarsht@ti.com> (raw)
Move video memory reservation for SPL at end of RAM so that it does
not interefere with reservations for next stage so that the next stage
need not have holes in between for passed regions and instead it can
maintain continuity in reservations.
Also catch the bloblist before starting reservations to avoid the same
problem.
While at it, also fill missing fields in video handoff struct before
passing it to next stage.
This is as per discussions at :
For moving SPL framebuffer reservation at end of RAM:
https://lore.kernel.org/all/CAPnjgZ3xSoe_G3yrqwuAvoiVjUfZ+YQgkOR0ZTVXGT9VK8TwJg@mail.gmail.com/
For filling missing video handoff fields :
https://lore.kernel.org/all/CAPnjgZ1Hs0rNf0JDirp6YPsOQ5=QqQSP9g9qRwLoOASUV8a4cw@mail.gmail.com/
Changelog:
V2:
- Make a generic function to reserve video memory at SPL stage.
- Add debug prints while skipping framebuffer allocation at uboot.
- Correct commenting style as suggested.
V3:
- Change spl_reserve_video to spl_reserve_video_from_ram_top
which enforce framebuffer reservation from end of RAM.
- Use gd->ram_top instead of local ram_top and update
gd->reloc_addr after each reservation.
- Print error message on framebuffer reservation.
- Update SPL doc with spl splash screen specific info.
V4:
- Split patches into atomic commits.
- Remove duplicate check for video blob passed addresses and error out
if invalid address/size received from blob.
- Improve SPL documentation memory reservation scheme and print message
for video memory reservation from bloblist.
- Add Reviewed-By.
V5:
- Add comment for filling video handoff size with aligned size
- Use PHASE_BOARD_F while checking for U-boot proper stage
- Add Reviewed-by
Test logs:
https://gist.github.com/devarsht/30a3c1591270c9ebae00714b48d33058
Devarsh Thakkar (8):
spl: Enforce framebuffer reservation from end of RAM
arm: mach-k3: common: Reserve video memory from end of the RAM
board: ti: am62x: evm: Remove video_setup from spl_board_init
common/board_f: Catch bloblist before starting reservations
video: Skip framebuffer reservation if already reserved
video: Fill video handoff in video post probe
doc: spl: Add info for missing Kconfigs
doc: spl: Add info regarding memory reservation
arch/arm/mach-k3/common.c | 17 ++++++++++-----
board/ti/am62x/evm.c | 18 ----------------
common/board_f.c | 41 +++++++++++++++++++++++++++++++-----
common/spl/spl.c | 19 +++++++++++++++++
doc/develop/spl.rst | 37 ++++++++++++++++++++++++++++++++
drivers/video/video-uclass.c | 40 ++++++++++++++++++++++++-----------
include/spl.h | 10 +++++++++
7 files changed, 142 insertions(+), 40 deletions(-)
--
2.34.1
next reply other threads:[~2023-12-05 15:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:55 Devarsh Thakkar [this message]
2023-12-05 15:55 ` [PATCH v5 1/8] spl: Enforce framebuffer reservation from end of RAM Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 2/8] arm: mach-k3: common: Reserve video memory from end of the RAM Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 3/8] board: ti: am62x: evm: Remove video_setup from spl_board_init Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 4/8] common/board_f: Catch bloblist before starting reservations Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 5/8] video: Skip framebuffer reservation if already reserved Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 6/8] video: Fill video handoff in video post probe Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 7/8] doc: spl: Add info for missing Kconfigs Devarsh Thakkar
2023-12-05 15:55 ` [PATCH v5 8/8] doc: spl: Add info regarding memory reservation Devarsh Thakkar
2023-12-13 14:56 ` [PATCH v5 0/8] Move framebuffer reservation for SPL to RAM end Devarsh Thakkar
2023-12-26 9:47 ` Simon Glass
2024-01-08 8:02 ` Devarsh Thakkar
2024-01-29 16:11 ` Devarsh Thakkar
2024-01-30 1:54 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205155523.721784-1-devarsht@ti.com \
--to=devarsht@ti.com \
--cc=a-bhatia1@ti.com \
--cc=agust@denx.de \
--cc=bmeng.cn@gmail.com \
--cc=j-luthra@ti.com \
--cc=msuchanek@suse.de \
--cc=n-jain1@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=praneeth@ti.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
--cc=yangshiji66@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox