Re: [PATCH 06/11] lib/sha*.c: Update header list

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Sat, Dec 02, 2023 at 11:23:13AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Wed, 22 Nov 2023 at 06:12, Tom Rini <trini@konsulko.com> wrote:
> >
> > Cleanup the list of headers we include here. For the tools build we only
> > need to exclude <cyclic.h> as that's used by the target build for the
> > prototype for schedule(), and we don't need to get that via
> > <watchdog.h>. We can also make use of our <string.h> intentionally
> > existing as a redirection to <linux/string.h> to reduce ifdef'd lines.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> >  lib/sha1.c   | 7 ++-----
> >  lib/sha256.c | 7 ++-----
> >  lib/sha512.c | 6 +-----
> >  3 files changed, 5 insertions(+), 15 deletions(-)
> 
> As mentioned in my series this will prevent dropping the #ifdefs in this file:
> 
> #if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG)
> 
> Actually I see that I didn't send the v2 so I just did that now[1].
> 
> Regards,
> Simon
> 
> [1] https://patchwork.ozlabs.org/project/uboot/patch/20231202153400.537050-2-sjg@chromium.org/

Yes, I prefer what I did here instead of [1].

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]