From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2] arm: Add OVERLAY command to BSS section on ARM64
Date: Sun, 17 Dec 2023 13:41:06 -0500 [thread overview]
Message-ID: <20231217184106.GD2513409@bill-the-cat> (raw)
In-Reply-To: <20231217003347.194657-1-marek.vasut+renesas@mailbox.org>
[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]
On Sun, Dec 17, 2023 at 01:33:39AM +0100, Marek Vasut wrote:
> Avoid allocating and loading the BSS section.
>
> $ aarch64-linux-gnu-objdump -Sh u-boot
>
> Before:
> 10 .bss_start 00000000 00000000000f21d8 00000000000f21d8 001021d8 2**0
> CONTENTS, ALLOC, LOAD, DATA
> 11 .bss 000068f8 00000000000f2200 00000000000f2200 001021d8 2**6
> ALLOC
> 12 .bss_end 00000000 00000000000f8af8 00000000000f8af8 00108af8 2**0
> CONTENTS, ALLOC, LOAD, DATA
>
> After:
> 10 .bss_start 00000000 00000000000bf990 00000000000bf990 001021e0 2**0
> CONTENTS
> 11 .bss 000068e8 00000000000bf990 00000000000bf990 001021e0 2**4
> CONTENTS
> 12 .bss_end 00000000 00000000000c6278 00000000000c6278 00108ac8 2**0
> CONTENTS
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> V2: Replicate arch/arm/cpu/u-boot.lds BSS part verbatim
> ---
> arch/arm/cpu/armv8/u-boot.lds | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
The point I was trying to make before was that I wasn't 100% confident
that we need the linker scripts to match in that most of the relevant
code is in foo_64.S and not foo.S. But from a very quick grep it does
look similar enough that perhaps it was ported over directly enough that
we should be doing this with the linker scripts here too. Hopefully
throwing this in to -next soon enough will get any problems to fall out
quickly if we're wrong.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-12-17 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 0:33 [PATCH v2] arm: Add OVERLAY command to BSS section on ARM64 Marek Vasut
2023-12-17 18:41 ` Tom Rini [this message]
2024-02-06 14:44 ` Ilias Apalodimas
2024-02-06 16:35 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217184106.GD2513409@bill-the-cat \
--to=trini@konsulko.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox