From: Tom Rini <trini@konsulko.com>
To: Francis Laniel <francis.laniel@amarulasolutions.com>
Cc: u-boot@lists.denx.de,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Harald Seiler <hws@denx.de>, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v12 00/24] Modernize U-Boot shell
Date: Tue, 19 Dec 2023 14:31:59 -0500 [thread overview]
Message-ID: <20231219193159.GA3259099@bill-the-cat> (raw)
In-Reply-To: <20231208223025.55076-1-francis.laniel@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]
On Fri, Dec 08, 2023 at 11:30:01PM +0100, Francis Laniel wrote:
> Hi.
>
>
> During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based
> on LIL, to U-Boot [1, 2].
> While one of the goals of this contribution was to address the fact actual
> U-Boot shell, which is based on Busybox hush, is old there was a discussion
> about adding a new shell versus updating the actual one [3, 4].
>
> So, in this series, with Harald Seiler, we updated the actual U-Boot shell to
> reflect what is currently in Busybox source code.
> Basically, this contribution is about taking a snapshot of Busybox shell/hush.c
> file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs.
So, here's a problem. With:
commit a4bee0b45504397d71302cd1b186f5651424a332
Author: Simon Glass <sjg@chromium.org>
Date: Sun Oct 1 19:15:25 2023 -0600
bootstd: Add a menu option to bootflow scan
Allow showing a menu and automatically booting, with 'bootflow scan'.
This is more convenient than using a script.
Signed-off-by: Simon Glass <sjg@chromium.org>
We now have a test that checks for a return code getting populated back
up to the command line. With the old hush, we eventually get:
Boot failed (err=-14)
And -14 means -EFAULT which is what's expected. With the new hush we
get:
Boot failed (err=1)
Which isn't right. Can you please see what needs to be fixed and post
v13? Thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-12-19 19:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 22:30 [PATCH v12 00/24] Modernize U-Boot shell Francis Laniel
2023-12-08 22:30 ` [PATCH v12 01/24] test: Add framework to test hush behavior Francis Laniel
2023-12-08 22:30 ` [PATCH v12 02/24] test: hush: Test hush if/else Francis Laniel
2023-12-08 22:30 ` [PATCH v12 03/24] test/py: hush_if_test: Remove the test file Francis Laniel
2023-12-08 22:30 ` [PATCH v12 04/24] test: hush: Test hush variable expansion Francis Laniel
2023-12-08 22:30 ` [PATCH v12 05/24] test: hush: Test hush commands list Francis Laniel
2023-12-08 22:30 ` [PATCH v12 06/24] test: hush: Test hush loops Francis Laniel
2023-12-08 22:30 ` [PATCH v12 07/24] cli: Add Busybox upstream hush.c file Francis Laniel
2023-12-08 22:30 ` [PATCH v12 08/24] cli: Port upstream Busybox hush to U-Boot Francis Laniel
2023-12-08 22:30 ` [PATCH v12 09/24] cli: Add menu for hush parser Francis Laniel
2023-12-08 22:30 ` [PATCH v12 10/24] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2023-12-08 22:30 ` [PATCH v12 11/24] cmd: Add new cli command Francis Laniel
2023-12-08 22:30 ` [PATCH v12 12/24] cli: Enables using modern hush parser as command line parser Francis Laniel
2023-12-08 22:30 ` [PATCH v12 13/24] cli: hush_modern: Enable variables expansion for modern hush Francis Laniel
2023-12-08 22:30 ` [PATCH v12 14/24] cli: hush_modern: Add functions to be called from run_command() Francis Laniel
2023-12-08 22:30 ` [PATCH v12 15/24] cli: add modern hush as parser for run_command*() Francis Laniel
2023-12-08 22:30 ` [PATCH v12 16/24] test: hush: Fix instructions list tests for modern hush Francis Laniel
2023-12-08 22:30 ` [PATCH v12 17/24] test: hush: Fix variable expansion " Francis Laniel
2023-12-08 22:30 ` [PATCH v12 18/24] cli: hush_modern: Enable using < and > as string compare operators Francis Laniel
2023-12-08 22:30 ` [PATCH v12 19/24] cli: hush_modern: Enable if keyword Francis Laniel
2023-12-08 22:30 ` [PATCH v12 20/24] cli: hush_modern: Enable loops Francis Laniel
2023-12-08 22:30 ` [PATCH v12 21/24] test: hush: Fix loop tests for modern hush Francis Laniel
2023-12-08 22:30 ` [PATCH v12 22/24] cli: modern_hush: Add upstream commits up to 2nd October 2023 Francis Laniel
2023-12-08 22:30 ` [PATCH v12 23/24] cmd: Set modern hush as default shell Francis Laniel
2023-12-08 22:30 ` [PATCH v12 24/24] configs: Use old hush for several boards Francis Laniel
2023-12-11 15:23 ` Holger Brunck
2023-12-09 23:16 ` [PATCH v12 00/24] Modernize U-Boot shell Tom Rini
2023-12-12 20:36 ` Francis Laniel
2023-12-13 9:35 ` neil.armstrong
2023-12-19 19:31 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219193159.GA3259099@bill-the-cat \
--to=trini@konsulko.com \
--cc=francis.laniel@amarulasolutions.com \
--cc=hws@denx.de \
--cc=michael@amarulasolutions.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox