From: Tom Rini <trini@konsulko.com>
To: Mayuresh Chitale <mchitale@ventanamicro.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Shengyu Qu <wiagn233@outlook.com>,
Sean Anderson <seanga2@gmail.com>, Simon Glass <sjg@chromium.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled
Date: Thu, 21 Dec 2023 16:06:52 -0500 [thread overview]
Message-ID: <20231221210652.GN2513409@bill-the-cat> (raw)
In-Reply-To: <20231116171612.143910-1-mchitale@ventanamicro.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Thu, Nov 16, 2023 at 10:46:12PM +0530, Mayuresh Chitale wrote:
> If FS_LOADER is enabled for the SPL then the build fails with the error:
>
> fs/fs.o:(.data.rel.fstypes+0x128):
> undefined reference to `smh_fs_set_blk_dev'
> fs/fs.o:(.data.rel.fstypes+0x140):
> undefined reference to `smh_fs_size'
> fs/fs.o:(.data.rel.fstypes+0x148):
> undefined reference to `smh_fs_read'
> fs/fs.o:(.data.rel.fstypes+0x150):
> undefined reference to `smh_fs_write'
>
> Fix the error by populating the semihosting entry in the fs_types array
> only for non-SPL builds.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-12-21 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:16 [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled Mayuresh Chitale
2023-11-16 18:33 ` Tom Rini
2023-11-16 18:39 ` Sean Anderson
2023-12-21 21:06 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221210652.GN2513409@bill-the-cat \
--to=trini@konsulko.com \
--cc=ilias.apalodimas@linaro.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mchitale@ventanamicro.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox