public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Harald Seiler <hws@denx.de>, Simon Glass <sjg@chromium.org>,
	Francis Laniel <francis.laniel@amarulasolutions.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Stephen Carlson <stcarlso@linux.microsoft.com>,
	Eddie James <eajames@linux.ibm.com>,
	Alexander Gendin <agendin@matrox.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Sean Anderson <seanga2@gmail.com>
Subject: [PATCH v13 01/24] test: Add framework to test hush behavior
Date: Fri, 22 Dec 2023 22:02:21 +0100	[thread overview]
Message-ID: <20231222210244.91830-2-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20231222210244.91830-1-francis.laniel@amarulasolutions.com>

Introduce a new subcommand to ut: ut hush.
For the moment, this command does nothing, future commits will add tests which
will be run on command call.

Note that CONFIG_HUSH_PARSER must be defined to compile this new subcommand.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 include/test/hush.h     | 15 +++++++++++++++
 include/test/suites.h   |  1 +
 test/Makefile           |  3 +++
 test/cmd_ut.c           |  6 ++++++
 test/hush/Makefile      |  6 ++++++
 test/hush/cmd_ut_hush.c | 20 ++++++++++++++++++++
 6 files changed, 51 insertions(+)
 create mode 100644 include/test/hush.h
 create mode 100644 test/hush/Makefile
 create mode 100644 test/hush/cmd_ut_hush.c

diff --git a/include/test/hush.h b/include/test/hush.h
new file mode 100644
index 0000000000..cca66544a0
--- /dev/null
+++ b/include/test/hush.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#ifndef __TEST_HUSH_H__
+#define __TEST_HUSH_H__
+
+#include <test/test.h>
+
+/* Declare a new environment test */
+#define HUSH_TEST(_name, _flags)	UNIT_TEST(_name, _flags, hush_test)
+
+#endif /* __TEST_HUSH_H__ */
diff --git a/include/test/suites.h b/include/test/suites.h
index 49224d8ea2..365d5f20df 100644
--- a/include/test/suites.h
+++ b/include/test/suites.h
@@ -43,6 +43,7 @@ int do_ut_env(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_exit(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_font(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_lib(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_loadm(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]);
 int do_ut_log(struct cmd_tbl *cmdtp, int flag, int argc, char * const argv[]);
diff --git a/test/Makefile b/test/Makefile
index 6b8a1506f5..9aeef02f9e 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -17,6 +17,9 @@ obj-$(CONFIG_FUZZ) += fuzz/
 ifndef CONFIG_SANDBOX_VPL
 obj-$(CONFIG_UNIT_TEST) += lib/
 endif
+ifneq ($(CONFIG_HUSH_PARSER),)
+obj-$(CONFIG_$(SPL_)CMDLINE) += hush/
+endif
 obj-$(CONFIG_$(SPL_)CMDLINE) += print_ut.o
 obj-$(CONFIG_$(SPL_)CMDLINE) += str_ut.o
 obj-$(CONFIG_UT_TIME) += time_ut.o
diff --git a/test/cmd_ut.c b/test/cmd_ut.c
index 1b934b2329..0677ce0cd1 100644
--- a/test/cmd_ut.c
+++ b/test/cmd_ut.c
@@ -121,6 +121,9 @@ static struct cmd_tbl cmd_ut_sub[] = {
 #ifdef CONFIG_CMD_ADDRMAP
 	U_BOOT_CMD_MKENT(addrmap, CONFIG_SYS_MAXARGS, 1, do_ut_addrmap, "", ""),
 #endif
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+	U_BOOT_CMD_MKENT(hush, CONFIG_SYS_MAXARGS, 1, do_ut_hush, "", ""),
+#endif
 #ifdef CONFIG_CMD_LOADM
 	U_BOOT_CMD_MKENT(loadm, CONFIG_SYS_MAXARGS, 1, do_ut_loadm, "", ""),
 #endif
@@ -216,6 +219,9 @@ U_BOOT_LONGHELP(ut,
 #ifdef CONFIG_CONSOLE_TRUETYPE
 	"\nfont - font command"
 #endif
+#if CONFIG_IS_ENABLED(HUSH_PARSER)
+	"\nhush - Test hush behavior"
+#endif
 #ifdef CONFIG_CMD_LOADM
 	"\nloadm - loadm command parameters and loading memory blob"
 #endif
diff --git a/test/hush/Makefile b/test/hush/Makefile
new file mode 100644
index 0000000000..dfa2a92615
--- /dev/null
+++ b/test/hush/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# (C) Copyright 2021
+# Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+
+obj-y += cmd_ut_hush.o
diff --git a/test/hush/cmd_ut_hush.c b/test/hush/cmd_ut_hush.c
new file mode 100644
index 0000000000..48a1adbf28
--- /dev/null
+++ b/test/hush/cmd_ut_hush.c
@@ -0,0 +1,20 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#include <common.h>
+#include <command.h>
+#include <test/hush.h>
+#include <test/suites.h>
+#include <test/ut.h>
+
+int do_ut_hush(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
+{
+	struct unit_test *tests = UNIT_TEST_SUITE_START(hush_test);
+	const int n_ents = UNIT_TEST_SUITE_COUNT(hush_test);
+
+	return cmd_ut_category("hush", "hush_test_",
+			       tests, n_ents, argc, argv);
+}
-- 
2.34.1


  reply	other threads:[~2023-12-22 21:03 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22 21:02 [PATCH v13 00/24] Modernize U-Boot shell Francis Laniel
2023-12-22 21:02 ` Francis Laniel [this message]
2023-12-22 21:02 ` [PATCH v13 02/24] test: hush: Test hush if/else Francis Laniel
2023-12-22 21:02 ` [PATCH v13 03/24] test/py: hush_if_test: Remove the test file Francis Laniel
2023-12-22 21:02 ` [PATCH v13 04/24] test: hush: Test hush variable expansion Francis Laniel
2023-12-22 21:02 ` [PATCH v13 05/24] test: hush: Test hush commands list Francis Laniel
2023-12-22 21:02 ` [PATCH v13 06/24] test: hush: Test hush loops Francis Laniel
2023-12-22 21:02 ` [PATCH v13 07/24] cli: Add Busybox upstream hush.c file Francis Laniel
2023-12-22 21:02 ` [PATCH v13 08/24] cli: Port upstream Busybox hush to U-Boot Francis Laniel
2023-12-22 21:02 ` [PATCH v13 09/24] cli: Add menu for hush parser Francis Laniel
2023-12-22 21:02 ` [PATCH v13 10/24] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2023-12-22 21:02 ` [PATCH v13 11/24] cmd: Add new cli command Francis Laniel
2023-12-22 21:02 ` [PATCH v13 12/24] cli: Enables using modern hush parser as command line parser Francis Laniel
2023-12-22 21:02 ` [PATCH v13 13/24] cli: hush_modern: Enable variables expansion for modern hush Francis Laniel
2023-12-22 21:02 ` [PATCH v13 14/24] cli: hush_modern: Add functions to be called from run_command() Francis Laniel
2023-12-22 21:02 ` [PATCH v13 15/24] cli: add modern hush as parser for run_command*() Francis Laniel
2023-12-22 21:10   ` Francis Laniel
2023-12-22 21:23     ` Tom Rini
2023-12-26  9:46       ` Simon Glass
2023-12-29 18:55         ` Francis Laniel
2023-12-22 21:02 ` [PATCH v13 16/24] test: hush: Fix instructions list tests for modern hush Francis Laniel
2023-12-22 21:02 ` [PATCH v13 17/24] test: hush: Fix variable expansion " Francis Laniel
2023-12-22 21:02 ` [PATCH v13 18/24] cli: hush_modern: Enable using < and > as string compare operators Francis Laniel
2023-12-22 21:02 ` [PATCH v13 19/24] cli: hush_modern: Enable if keyword Francis Laniel
2023-12-22 21:02 ` [PATCH v13 20/24] cli: hush_modern: Enable loops Francis Laniel
2023-12-22 21:02 ` [PATCH v13 21/24] test: hush: Fix loop tests for modern hush Francis Laniel
2023-12-22 21:02 ` [PATCH v13 22/24] cli: modern_hush: Add upstream commits up to 2nd October 2023 Francis Laniel
2023-12-22 21:02 ` [PATCH v13 23/24] cmd: Set modern hush as default shell Francis Laniel
2023-12-22 21:02 ` [PATCH v13 24/24] configs: Use old hush for several boards Francis Laniel
2023-12-28 20:58 ` [PATCH v13 00/24] Modernize U-Boot shell Tom Rini
2023-12-29 18:55   ` Francis Laniel
2024-01-11 17:04     ` Francesco Dolcini
2024-01-15 17:34       ` Patrice CHOTARD
2024-01-16  0:46         ` Tom Rini
2024-01-16  7:08           ` Patrice CHOTARD
2024-01-16 17:25         ` Francis Laniel
2024-01-17 10:05           ` Patrice CHOTARD
2024-01-17 17:30             ` Francis Laniel
2024-01-17 17:39               ` Francesco Dolcini
2024-01-18  7:05                 ` Patrice CHOTARD
2024-01-18 14:09                   ` Tom Rini
2024-01-16 17:20       ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231222210244.91830-2-francis.laniel@amarulasolutions.com \
    --to=francis.laniel@amarulasolutions.com \
    --cc=agendin@matrox.com \
    --cc=eajames@linux.ibm.com \
    --cc=hws@denx.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=michael@amarulasolutions.com \
    --cc=seanga2@gmail.com \
    --cc=sjg@chromium.org \
    --cc=stcarlso@linux.microsoft.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox