From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>, Tom Rini <trini@konsulko.com>,
u-boot@lists.denx.de, NXP u-boot <uboot-imx@nxp.com>
Subject: Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env
Date: Thu, 11 Jan 2024 12:52:58 +0100 [thread overview]
Message-ID: <20240111125258.0e617a50@wsk> (raw)
In-Reply-To: <CAOMZO5CtLSkRPb-3RvS77za-y5zwkBirH4gGE_kwqLNao9bdSg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi Fabio,
> Hi Lukasz,
>
> On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > +serverip=10.8.217.79
> > +nfs_serverip=10.8.218.113
> > +gatewayip=10.8.209.250
>
> These IP addresses should not be hardcoded here.
>
> They were not present in xea.h originally. Please remove them.
Those are the IP's for customer's production setup. In that way I could
just point to mainline SHA1 and just use the sources without any further
adjustments.
I can agree, that on "common devel board" (like e.g. beaglebone) it
would be problematic to have it hardcoded, but as this one is customer
specific HW ...
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-01-11 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 11:06 [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env Lukasz Majewski
2024-01-11 11:06 ` [PATCH v2 2/3] arm: config: Enable CRC8 support in SPL on imx287 XEA board Lukasz Majewski
2024-01-11 11:06 ` [PATCH v2 3/3] arm: xea: Add support for boot image source descriptor in SPL Lukasz Majewski
2024-01-11 11:16 ` [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env Fabio Estevam
2024-01-11 11:49 ` Fabio Estevam
2024-01-11 12:11 ` Lukasz Majewski
2024-01-11 12:18 ` Lukasz Majewski
2024-01-11 11:52 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111125258.0e617a50@wsk \
--to=lukma@denx.de \
--cc=festevam@gmail.com \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox