Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

[Lukasz Majewski <lukma@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hi Fabio,

> On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam <festevam@gmail.com>
> wrote:
> >
> > Hi Lukasz,
> >
> > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski <lukma@denx.de>
> > wrote: 
> > > +serverip=10.8.217.79
> > > +nfs_serverip=10.8.218.113
> > > +gatewayip=10.8.209.250  
> >
> > These IP addresses should not be hardcoded here.
> >
> > They were not present in xea.h originally. Please remove them.  
> 
> One more thing: xea.h had:
> "dtbfile=imx28-xea.dtb\0"
> 
> but  I don't see dtbfile declared inside the new xea.env.

Thanks for spotting it - I've forgotten to remove it after moving
forward to fitImage.

I will remove it.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]