Re: [PATCH v13 00/24] Modernize U-Boot shell

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 2751 bytes --]

On Mon, Jan 15, 2024 at 06:34:24PM +0100, Patrice CHOTARD wrote:
> 
> 
> On 1/11/24 18:04, Francesco Dolcini wrote:
> > Hello Tom, Francis
> > 
> > On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> >> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> >>> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> >>>> During 2021 summer, Sean Anderson wrote a contribution to add a new shell,
> >>>> based on LIL, to U-Boot [1, 2].
> >>>> While one of the goals of this contribution was to address the fact actual
> >>>> U-Boot shell, which is based on Busybox hush, is old there was a
> >>>> discussion
> >>>> about adding a new shell versus updating the actual one [3, 4].
> >>>>
> >>>> So, in this series, with Harald Seiler, we updated the actual U-Boot shell
> >>>> to reflect what is currently in Busybox source code.
> >>>> Basically, this contribution is about taking a snapshot of Busybox
> >>>> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit
> >>>> U-Boot needs.
> >>>>
> >>>> [...]
> >>>
> >>> Applied to u-boot/next, thanks!
> >>
> >> Thank you for the merge!
> >> If there is any problem, do not hesitate to mail me and I will take care of 
> >> it!
> > 
> > This change, specifically setting the modern hush shell as default, is
> > breaking our boot script, just noticed since the current U-Boot master
> > has a regression for us.
> > 
> > We still need to figure out the exact details, here [1] you can find the
> > boot script (that has some placeholder that is replaced during build).
> > 
> > and the error is something like:
> > 
> > ```
> > ## Executing script at 90280000
> > Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> > 69025 bytes read in 11 ms (6 MiB/s)
> > 82 bytes read in 9 ms (8.8 KiB/s)
> > Working FDT set to 90200000
> > syntax error at 'done'HUSH died!
> > resetting ...
> > ```
> > 
> > that I _assume_ comes from this line
> > 
> >     env set set_apply_overlays 'env set apply_overlays "for overlay_file in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} && ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt apply \\${loadaddr}; env set overlay_file; done; true"'
> > 
> > [1] https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u-boot/u-boot-distro-boot/boot.cmd.in
> > 
> > Francesco
> > 
> 
> 
> Hi all
> 
> I observed a similar issue with STM32MP157c-DK2 board.
> Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot crashes :

I wonder if:
https://patchwork.ozlabs.org/project/uboot/patch/20240115134656.50917-1-heinrich.schuchardt@canonical.com/
is relevant to this problem or not.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]