Re: [PATCH v3 4/4] sunxi: Enable SPL FIT loading for 32-bit SoCs

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 8 Dec 2023 01:39:45 +0000
Andre Przywara <andre.przywara@arm.com> wrote:

Hi Samuel,

> On Tue, 31 Oct 2023 00:17:41 -0500
> Samuel Holland <samuel@sholland.org> wrote:
> 
> Hi,
> 
> > Now that 32-bit SoCs can load U-Boot proper (and possibly other
> > firmware) from a FIT, use this method by default. SPL_FIT_IMAGE_TINY is
> > required to stay within the 24 or 32 KiB SPL size limit on early SoCs;
> > for consistency, enable it everywhere.  
> 
> Mmh, so that changes the build for an awful lot of boards, especially
> old ones that no one can be bothered to test anymore. I am bit scared
> of that change there, especially with the limited SRAM size there.
> 
> I think the main motivation stems from crust on H3, and since H3 boards
> are still in good use and get tested, I'd prefer to enable it just for
> H3 boards, at least for now.
> If we don't hear anything bad for a while, we could try to enable it
> (by default) on the other SoCs as well.
> 
> What do you think?

Any ideas here? I plan to take the other three patches, which would
already allow people to enable FIT in their (def)config.
I can just leave this one off for now, and we can merge a changed
version later?

Cheers,
Andre

> > 
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > 
> > (no changes since v2)
> > 
> > Changes in v2:
> >  - New patch for v2, split from the .dtsi changes
> > 
> >  arch/arm/Kconfig   | 1 +
> >  common/spl/Kconfig | 3 +--
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index d812685c984..42781d02f0f 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1167,6 +1167,7 @@ config ARCH_SUNXI
> >  	imply SPL_GPIO
> >  	imply SPL_LIBCOMMON_SUPPORT
> >  	imply SPL_LIBGENERIC_SUPPORT
> > +	imply SPL_LOAD_FIT
> >  	imply SPL_MMC if MMC
> >  	imply SPL_POWER
> >  	imply SPL_SERIAL
> > diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> > index a0968ff1065..aebbfbf99d2 100644
> > --- a/common/spl/Kconfig
> > +++ b/common/spl/Kconfig
> > @@ -567,8 +567,7 @@ config SYS_MMCSD_RAW_MODE_EMMC_BOOT_PARTITION
> >  config SPL_FIT_IMAGE_TINY
> >  	bool "Remove functionality from SPL FIT loading to reduce size"
> >  	depends on SPL_FIT
> > -	default y if MACH_SUN50I || MACH_SUN50I_H5 || SUN50I_GEN_H6
> > -	default y if ARCH_IMX8M || ARCH_IMX9
> > +	default y if ARCH_IMX8M || ARCH_IMX9 || ARCH_SUNXI
> >  	help
> >  	  Enable this to reduce the size of the FIT image loading code
> >  	  in SPL, if space for the SPL binary is very tight.  
>