[PATCH 1/2] imx8m: Enable LTO by default

[PATCH 1/2] imx8m: Enable LTO by default

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size
could not fit into the internal SRAM of some imx8m targets:

   aarch64:  +   imx8mm_phg
+aarch64-linux-ld.bfd: u-boot-spl section `__u_boot_list' will not fit in region `.sram'
+aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes

Select LTO to prevent that.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/mach-imx/imx8m/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index b1937198402f..328c3e388051 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -5,6 +5,7 @@ config IMX8M
 	select BINMAN
 	select GICV3 if ARMV8_PSCI
 	select HAS_CAAM
+	select LTO
 	select ROM_UNIFIED_SECTIONS
 	select ARMV8_CRYPTO
 
-- 
2.34.1

[PATCH 2/2] arm: imx: imx8m: Enable the SError exception

[Fabio Estevam]

From: Ye Li <ye.li@nxp.com>

To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror")
we need to enable the SError exception and install vector in SPL.

Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reported-by: Thomas Schaefer <thomas.schaefer@kontron.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/mach-imx/imx8m/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index 328c3e388051..eb0488a9e8bf 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -13,14 +13,17 @@ config IMX8MQ
 	bool
 	select IMX8M
 	select CLK_IMX8MQ
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MM
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MN
 	bool
 	select IMX8M
+	select ARMV8_SPL_EXCEPTION_VECTORS
 
 config IMX8MP
 	bool
-- 
2.34.1

Re: [PATCH 2/2] arm: imx: imx8m: Enable the SError exception

[Marek Vasut]

On 1/18/24 16:06, Fabio Estevam wrote:
> From: Ye Li <ye.li@nxp.com>
> 
> To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror")
> we need to enable the SError exception and install vector in SPL.

This really does need better commit message, sorry.

Details, please.

What does trigger the SError ?

Re: [PATCH 2/2] arm: imx: imx8m: Enable the SError exception

[Fabio Estevam]

On Thu, Jan 18, 2024 at 4:08 PM Marek Vasut <marex@denx.de> wrote:
>
> On 1/18/24 16:06, Fabio Estevam wrote:
> > From: Ye Li <ye.li@nxp.com>
> >
> > To work with commit 2f3c92060dcd ("imx8m: workaround ROM serror")
> > we need to enable the SError exception and install vector in SPL.
>
> This really does need better commit message, sorry.
>
> Details, please.
>
> What does trigger the SError ?

Ye Li, please improve the commit message and send a v2.

Thanks

Re: [PATCH 1/2] imx8m: Enable LTO by default

[Marek Vasut]

On 1/18/24 16:06, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size
> could not fit into the internal SRAM of some imx8m targets:
> 
>     aarch64:  +   imx8mm_phg
> +aarch64-linux-ld.bfd: u-boot-spl section `__u_boot_list' will not fit in region `.sram'
> +aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes
> 
> Select LTO to prevent that.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marek Vasut <marex@denx.de>

I wouldn't mind seeing LTO enabled for all of ARM64 eventually, but 
that's for another patch.

Re: [PATCH 1/2] imx8m: Enable LTO by default

[Fabio Estevam]

On Thu, Jan 18, 2024 at 12:06 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> In an attempt to select ARMV8_SPL_EXCEPTION_VECTORS, the SPL size
> could not fit into the internal SRAM of some imx8m targets:
>
>    aarch64:  +   imx8mm_phg
> +aarch64-linux-ld.bfd: u-boot-spl section `__u_boot_list' will not fit in region `.sram'
> +aarch64-linux-ld.bfd: region `.sram' overflowed by 1824 bytes
>
> Select LTO to prevent that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied only this one, thanks.