Re: [PATCH v2 RESEND 2/2] nvme: Update nvme_scan_namespace to keep trying on busy

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

On Thu, Jan 18, 2024 at 02:29:11PM -0800, Moritz Fischer wrote:
> On Tue, Jan 9, 2024 at 9:05 PM Moritz Fischer <moritzf@google.com> wrote:
> >
> > A busy controller shouldn't be game-over for all controllers,
> > so keep trying on hitting -EBUSY.
> >
> > This change brings the actual behavior of the routine in line
> > with what the descriptions says.
> >
> > Fixes: 982388eaa991 ("nvme: Add NVM Express driver support")
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Moritz Fischer <moritzf@google.com>
> > ---
> >  drivers/nvme/nvme.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
> > index ec45f831a3..59a139baa0 100644
> > --- a/drivers/nvme/nvme.c
> > +++ b/drivers/nvme/nvme.c
> > @@ -695,7 +695,9 @@ int nvme_scan_namespace(void)
> >                 if (ret) {
> >                         log_err("Failed to probe '%s': err=%dE\n", dev->name,
> >                                 ret);
> > -                       return ret;
> > +                       /* Bail if we ran out of memory, else keep trying */
> > +                       if (ret != -EBUSY)
> > +                               return ret;
> >                 }
> >         }
> >
> > --
> > 2.43.0.472.g3155946c3a-goog
> >
> 
> Gently ping on this. Is anything wrong with this series or why does it
> keep falling through the cracks?

Randomly, I'm testing this (and your other patches, and some others) at
the moment. Sorry for the delay.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]