Re: [PATCH v2] net: sun8i-emac: Add support for fixed-link phy

[Andre Przywara <andre.przywara@arm.com>]

On Sat, 20 Jan 2024 19:26:24 +0300
Maksim Kiselev <bigunclemax@gmail.com> wrote:

> Make the "phy-handle" property optional, which allows support
> for a fixed-link phy configuration.
> 
> Thus if the "phy-handle" is present in a DT, then driver will work as
> before. Otherwise, phyaddr initialization will not be necessary,
> as it is not needed in case of a fixed-link config.
> 
> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com>

Thanks, looks good now:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Queued for the first PR.

Cheers,
Andre


> ---
>  drivers/net/sun8i_emac.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
> index a12f7e32e8..8bff4fe9a9 100644
> --- a/drivers/net/sun8i_emac.c
> +++ b/drivers/net/sun8i_emac.c
> @@ -833,11 +833,8 @@ static int sun8i_emac_eth_of_to_plat(struct udevice *dev)
>  	priv->use_internal_phy = false;
>  
>  	offset = fdtdec_lookup_phandle(gd->fdt_blob, node, "phy-handle");
> -	if (offset < 0) {
> -		debug("%s: Cannot find PHY address\n", __func__);
> -		return -EINVAL;
> -	}
> -	priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
> +	if (offset >= 0)
> +		priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1);
>  
>  	pdata->phy_interface = dev_read_phy_mode(dev);
>  	debug("phy interface %d\n", pdata->phy_interface);