public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: sbabic@denx.de, uboot-imx@nxp.com, u-boot@lists.denx.de,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v2 2/3] mx6sabresd: Convert to watchdog driver model
Date: Fri, 2 Feb 2024 11:07:02 -0500	[thread overview]
Message-ID: <20240202160702.GD1152441@bill-the-cat> (raw)
In-Reply-To: <20240202160405.4126192-2-festevam@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Fri, Feb 02, 2024 at 01:04:04PM -0300, Fabio Estevam wrote:

> From: Fabio Estevam <festevam@denx.de>
> 
> Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused
> the 'reset' command in U-Boot to not cause a board reset.
> 
> Fix it by switching to the watchdog driver model via sysreset, which
> is the preferred method for implementing the watchdog reset.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - None.
> 
>  arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi | 9 +++++++++
>  configs/mx6sabresd_defconfig             | 3 +++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> index 5c4101b76da2..9e9c4422f00e 100644
> --- a/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> +++ b/arch/arm/dts/imx6qdl-sabresd-u-boot.dtsi
> @@ -9,6 +9,11 @@
>  	aliases {
>  		mmc1 = &usdhc3;
>  	};
> +	wdt-reboot {
> +		compatible = "wdt-reboot";
> +		wdt = <&wdog2>;
> +		bootph-pre-ram;
> +	};
>  };
>  
>  &usdhc3 {
> @@ -18,3 +23,7 @@
>  &pinctrl_usdhc3 {
>  	bootph-pre-ram;
>  };
> +
> +&wdog2 {
> +	bootph-pre-ram;
> +};

Can all of this be upstreamed as well?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2024-02-02 16:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 16:04 [PATCH v2 1/3] mx6sabresd: Fix U-Boot corruption after saving the environment Fabio Estevam
2024-02-02 16:04 ` [PATCH v2 2/3] mx6sabresd: Convert to watchdog driver model Fabio Estevam
2024-02-02 16:07   ` Tom Rini [this message]
2024-02-02 16:17     ` Fabio Estevam
2024-02-02 17:15       ` Tom Rini
2024-02-02 16:04 ` [PATCH v2 3/3] mx6sabresd: Remove board_phy_config() Fabio Estevam
2024-02-02 20:14   ` Igor Opaniuk
2024-02-02 16:06 ` [PATCH v2 1/3] mx6sabresd: Fix U-Boot corruption after saving the environment Tom Rini
2024-02-02 20:34 ` Igor Opaniuk
2024-02-02 21:16   ` Igor Opaniuk
2024-02-08 14:34 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240202160702.GD1152441@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox