Re: [PATCH v7] fdt: Allow the devicetree to come from a bloblist

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2573 bytes --]

On Tue, Jan 23, 2024 at 01:03:00PM -0500, Tom Rini wrote:
> On Tue, Jan 23, 2024 at 11:27:57AM +0000, Conor Dooley wrote:
> > On Mon, Jan 22, 2024 at 06:55:01PM +0000, Conor Dooley wrote:
> > > On Mon, Jan 22, 2024 at 01:47:17PM -0500, Tom Rini wrote:
> > > > On Mon, Jan 22, 2024 at 06:36:31PM +0000, Conor Dooley wrote:
> > > > > Hey,
> > > > > 
> > > > > On Tue, Jan 16, 2024 at 01:48:06PM +0000, Conor Dooley wrote:
> > > > > > Yo,
> > > > > > 
> > > > > > On Wed, Jan 03, 2024 at 06:49:19PM -0700, Simon Glass wrote:
> > > > > > > Standard passage provides for a bloblist to be passed from one firmware
> > > > > > > phase to the next. That can be used to pass the devicetree along as well.
> > > > > > > Add an option to support this.
> > > > > > > 
> > > > > > > Tests for this will be added as part of the Universal Payload work.
> > > > > > > 
> > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > > > > > 
> > > > > > Since this was merged into master, U-Boot is no longer booting on my
> > > > > > icicle kit (At least that's what my bisection tells me). This is a
> > > > > > RISC-V board and U-Boot for it is built from
> > > > > > microchip_mpfs_icicle_defconfig.
> > > > > > 
> > > > > > There's zero output on the console from U-Boot at all, the last thing
> > > > > > that I see is OpenSBI before things grind to a halt.
> > > > > 
> > > > > Just wondering if there's anything I can do to help this one along?
> > > > > Got a red CI complaining at me every morning about it :|
> > > > 
> > > > Well, can you please look in to what part of this is causing the
> > > > failure? I don't really see what would have changed on
> > > > microchip_mpfs_icicle_defconfig from this as BLOBLIST isn't set before
> > > > nor after this change.
> > > 
> > > Sure. I'll try to look into it more tomorrow.
> > 
> > I gave it a try, it seems to be the FDTSRC_BLOBLIST additions that kill
> > it, not the actual code in fdtdec_setup().
> 
> Well that's very unexpected. Can you see what boundary we're crossing or
> whatever has overflowed now or something on your platform?

And you know what else was not expected? The issue randomly disappearing
a few days after I sent this email. Or maybe that should be expected
given how the issue actually cropped up in the first place.
I didn't have a chance yet to see how this particular patch may have
interacted with the sections etc, but looking into it is still on my
todo list, just much lower down now that things actually boot again for
me...

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]