Re: [PATCH v2] arm: sunxi: Reduce inrush current on Olimex A20-OLinuXino_MICRO configs

[Andre Przywara <andre.przywara@arm.com>]

On Sun, 11 Feb 2024 21:52:13 +0100
Philippe Coval <rzr@users.sf.net> wrote:

Hi Philippe,

> This change fix reboot, both configurations
> were tested on my Olimex A20 Micro Rev E with debian-12.
> 
> This issue was also present and fixed on A20 Lime2 (in 8311e84b18),
> quoting Olliver Schinagl:
> 
>     The lime2 features a too large capacitor on the LDO3 output, which
>     causes the PMIC to shutdown when enabling power. To be able to still
>     boot up however, we must gradually enable power on LDO3 for this board.
>     We do this by enabling both the inrush quirk and the maximum slope the
>     AXP209 supports.
> 
> Link: https://bugs.debian.org/1060752
> Cc: Olliver Schinagl <oliver@schinagl.nl>
> Cc: Priit Laes <plaes@plaes.org>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Philippe Coval <rzr@users.sf.net>

Thanks for the changes, this looks good to me now.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

I will queue this for the sunxi/master.

Cheers,
Andre

> ---
> 
> Changes in v2:
> - Add qirk to eMMC configuration of same machine
> 
>  configs/A20-OLinuXino_MICRO-eMMC_defconfig | 1 +
>  configs/A20-OLinuXino_MICRO_defconfig      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/configs/A20-OLinuXino_MICRO-eMMC_defconfig b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> index ca5869f43d..2f26b0ca01 100644
> --- a/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> +++ b/configs/A20-OLinuXino_MICRO-eMMC_defconfig
> @@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_MII=y
>  CONFIG_SUN7I_GMAC=y
>  CONFIG_SUN7I_GMAC_FORCE_TXERR=y
> +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
>  CONFIG_AXP_ALDO3_VOLT=2800
>  CONFIG_AXP_ALDO4_VOLT=2800
>  CONFIG_SCSI=y
> diff --git a/configs/A20-OLinuXino_MICRO_defconfig b/configs/A20-OLinuXino_MICRO_defconfig
> index db4270f9b2..673ab85c8a 100644
> --- a/configs/A20-OLinuXino_MICRO_defconfig
> +++ b/configs/A20-OLinuXino_MICRO_defconfig
> @@ -20,6 +20,7 @@ CONFIG_ETH_DESIGNWARE=y
>  CONFIG_MII=y
>  CONFIG_SUN7I_GMAC=y
>  CONFIG_SUN7I_GMAC_FORCE_TXERR=y
> +CONFIG_AXP_ALDO3_INRUSH_QUIRK=y
>  CONFIG_AXP_ALDO3_VOLT=2800
>  CONFIG_AXP_ALDO4_VOLT=2800
>  CONFIG_SCSI=y