* [PATCH] bootdev: drop unnecessary assert on bootflow->bdev
@ 2024-02-12 9:35 Thomas Weißschuh
2024-03-04 15:27 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2024-02-12 9:35 UTC (permalink / raw)
To: Simon Glass, Tom Rini; +Cc: u-boot, Benedikt Spranger, Thomas Weißschuh
Not all flows have a device and the function already contains logic to
handle this case.
Fixes: eccb25cd5922 ("bootstd: Allow the bootdev to be optional in bootflows")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
boot/bootdev-uclass.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c
index 35afb93c0e73..0fa6dad8b11b 100644
--- a/boot/bootdev-uclass.c
+++ b/boot/bootdev-uclass.c
@@ -39,7 +39,6 @@ int bootdev_add_bootflow(struct bootflow *bflow)
struct bootflow *new;
int ret;
- assert(bflow->dev);
ret = bootstd_get_priv(&std);
if (ret)
return ret;
---
base-commit: e8f2404e093daf6cc3ac2b3233e3c6770d13e371
change-id: 20240209-bootdev-assert-11714f63d72d
Best regards,
--
Thomas Weißschuh <thomas.weissschuh@linutronix.de>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bootdev: drop unnecessary assert on bootflow->bdev
2024-02-12 9:35 [PATCH] bootdev: drop unnecessary assert on bootflow->bdev Thomas Weißschuh
@ 2024-03-04 15:27 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2024-03-04 15:27 UTC (permalink / raw)
To: Thomas Weißschuh; +Cc: Simon Glass, u-boot, Benedikt Spranger
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
On Mon, Feb 12, 2024 at 10:35:12AM +0100, Thomas Weißschuh wrote:
> Not all flows have a device and the function already contains logic to
> handle this case.
>
> Fixes: eccb25cd5922 ("bootstd: Allow the bootdev to be optional in bootflows")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-04 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-12 9:35 [PATCH] bootdev: drop unnecessary assert on bootflow->bdev Thomas Weißschuh
2024-03-04 15:27 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox